Skip to content

Add support for multi platform image #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 30, 2025
Merged

Add support for multi platform image #1010

merged 13 commits into from
Jul 30, 2025

Conversation

adarshagrawal38
Copy link
Contributor

@adarshagrawal38 adarshagrawal38 commented Jun 19, 2025 •
edited by danehans
Loading

Partially Fixes #685

@netlify Netlify
Copy link

netlify bot commented Jun 19, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7f12696
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/686229526c11880008b1e8a5
😎 Deploy Preview https://deploy-preview-1010--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot requested review from kfswain and robscott June 19, 2025 07:47
@k8s-ci-robot
Copy link
Contributor

Hi @adarshagrawal38. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2025
@adarshagrawal38 adarshagrawal38 mentioned this pull request Jun 19, 2025
Closed
@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 19, 2025
kfswain
kfswain reviewed Jun 19, 2025
View reviewed changes
Dockerfile Outdated
@@ -5,9 +5,11 @@ ARG BASE_IMAGE=gcr.io/distroless/static:nonroot

## Multistage build
FROM ${BUILDER_IMAGE} AS builder
ARG TARGETOS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set the default value to the previous GOOS & GOARCH

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sure, pushed in new commit

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you can keep the ARGs if needed, I was just asking to move the default values to there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARG parameter is no longger needed

@kfswain
Copy link
Collaborator

kfswain commented Jun 24, 2025

Heya @adarshagrawal38! Any updates here?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2025
@adarshagrawal38
Copy link
Contributor Author

Heya @adarshagrawal38! Any updates here?

Hi @kfswain, after enabling multi platform build both the images, test cases are getting failed, trying to find some solution for it.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2025
danehans
danehans reviewed Jun 27, 2025
View reviewed changes
Makefile Outdated
@@ -191,9 +191,16 @@ image-build: ## Build the EPP image using Docker Buildx.
$(LOAD) \
$(IMAGE_BUILD_EXTRA_OPTS) ./

.PHONY: multi-platform-init
multi-platform-init: ## Set up Docker Buildx for multi-platform builds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfswain @ahg-g where is the job that build the epp:main image?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is here:
https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/cloudbuild.yaml

danehans
danehans reviewed Jun 27, 2025
View reviewed changes
Makefile Outdated
.PHONY: image-push
image-push: PUSH=--push ## Build the EPP image and push it to $IMAGE_REPO.
image-push: image-build
image-push: PLATFORMS=linux/amd64,linux/arm64
image-push: multi-platform-init image-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to support both dev (single-arch) and release (multi-arch) workflows. Here is an untested example of what I was thinking to support multi-arch and support the different dev/release flows. @kfswain @ahg-g this does require updating the CI job, e.g. MULTI=true, to build multi-arch images.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2025
@adarshagrawal38
Copy link
Contributor Author

Hi @danehans Please do have a look at updated PR.

@danehans
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adarshagrawal38, danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025
@danehans danehans merged commit 2c88636 into kubernetes-sigs:main Jul 30, 2025
9 checks passed
@danehans
Copy link
Contributor

@adarshagrawal38, thanks for submitting this PR. To close #685, we need to apply the same workflow for the other binaries, e.g. BBR. Do you mind taking this on?

@adarshagrawal38 adarshagrawal38 deleted the multi-platform branch July 31, 2025 06:20
@adarshagrawal38
Copy link
Contributor Author

adarshagrawal38 commented Jul 31, 2025 •
edited
Loading

@adarshagrawal38, thanks for submitting this PR. To close #685, we need to apply the same workflow for the other binaries, e.g. BBR. Do you mind taking this on?

Hey @danehans, yeah sure I would be happy to work on it, I will raise pr for BBR and syncer binaries

Updated the make file here: #1268

@adarshagrawal38 adarshagrawal38 mentioned this pull request Jul 31, 2025
Open
@danehans
Copy link
Contributor

danehans commented Aug 2, 2025

@adarshagrawal38 PTAL #1286. See https://kubernetes.slack.com/archives/C08E3RZMT2P/p1754106425527659 for aditional context.

zetxqx added a commit to zetxqx/gateway-api-inference-extension that referenced this pull request Aug 4, 2025
@zetxqx
revert kubernetes-sigs#1010.
9702c44
@zetxqx zetxqx mentioned this pull request Aug 4, 2025
Merged
k8s-ci-robot pushed a commit that referenced this pull request Aug 4, 2025
@zetxqx
revert #1010. (#1300)
f092291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danehans danehans danehans left review comments

@nirrozenbaum nirrozenbaum nirrozenbaum left review comments

@kfswain kfswain kfswain left review comments

@robscott robscott Awaiting requested review from robscott

Assignees

@danehans danehans

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-platform builds
5 participants
@adarshagrawal38 @k8s-ci-robot @nirrozenbaum @kfswain @danehans