Skip to content

fix(conformance): Use pinned version of EPP for conformance test instead of main. #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(conformance): Use pinned version of EPP for conformance test instead of main. #1262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conformance/resources/manifests/manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ spec:
terminationGracePeriodSeconds: 130
containers:
- name: epp
image: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp:main
image: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp:v20250725-fb2dfd8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use latest release version? The meaning of v20250725-fb2dfd8 is confusing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it. Because the current conformance test is using inferencePool v1(https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/conformance/resources/manifests/manifests.yaml#L242) version, however the already released EPP version does not support v1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be a temporary state until v1 is fully supported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirrozenbaum yes, I would expect that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any time estimation for when is it expected?

I understand that current work on the transition to v1 is still not completed.
having said that, we should keep in mind that pinning the version has a different issue of not getting updates that are merged to main, like bug fixes, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you on the cons on the pinned image. Use a release version is way better. I'll currently put this PR on hold for further discussion. If some implementers found conformance tests failure, we can ask them to use a pinned version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zetxqx since we decided to support both v1 and v1alpha2, do we still need this issue/PR?
or can we close?

imagePullPolicy: Always
args:
- --pool-name
Expand Down Expand Up @@ -290,7 +290,7 @@ spec:
terminationGracePeriodSeconds: 130
containers:
- name: epp
image: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp:main
image: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp:v20250725-fb2dfd8
imagePullPolicy: Always
args:
- --pool-name
Expand Down