Skip to content

fix(conformance): Use pinned version of EPP for conformance test instead of main. #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(conformance): Use pinned version of EPP for conformance test instead of main. #1262

wants to merge 1 commit into from
+2 −2

Conversation

zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Jul 29, 2025 •
edited
Loading

Fixes #1258, Used a pinned version of EPP for conformance tests

@netlify Netlify
Copy link

netlify bot commented Jul 29, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 5ade7d0
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68894ed6d14d640008d9fb49
😎 Deploy Preview https://deploy-preview-1262--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zetxqx
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zetxqx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2025
capri-xiyue
capri-xiyue reviewed Jul 30, 2025
View reviewed changes
conformance/resources/manifests/manifests.yaml
@@ -196,7 +196,7 @@ spec:
terminationGracePeriodSeconds: 130
containers:
- name: epp
image: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp:main
image: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp:v20250725-fb2dfd8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use latest release version? The meaning of v20250725-fb2dfd8 is confusing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it. Because the current conformance test is using inferencePool v1(https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/conformance/resources/manifests/manifests.yaml#L242) version, however the already released EPP version does not support v1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be a temporary state until v1 is fully supported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirrozenbaum yes, I would expect that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any time estimation for when is it expected?

I understand that current work on the transition to v1 is still not completed.
having said that, we should keep in mind that pinning the version has a different issue of not getting updates that are merged to main, like bug fixes, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you on the cons on the pinned image. Use a release version is way better. I'll currently put this PR on hold for further discussion. If some implementers found conformance tests failure, we can ask them to use a pinned version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zetxqx since we decided to support both v1 and v1alpha2, do we still need this issue/PR?
or can we close?

@zetxqx
Copy link
Contributor Author

zetxqx commented Jul 30, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2025
@zetxqx zetxqx marked this pull request as draft July 30, 2025 17:57
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capri-xiyue capri-xiyue capri-xiyue left review comments

@kfswain kfswain Awaiting requested review from kfswain

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use pinned tags in conformance tests
4 participants
@zetxqx @k8s-ci-robot @nirrozenbaum @capri-xiyue