Skip to content

Conversation

zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Jul 29, 2025

Fixes #1258, Used a pinned version of EPP for conformance tests

Copy link

netlify bot commented Jul 29, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit aa2eee6
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c35efe6db7d30008300a7e
😎 Deploy Preview https://deploy-preview-1262--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zetxqx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Jul 30, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2025
@zetxqx zetxqx marked this pull request as draft July 30, 2025 17:57
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 30, 2025
@kfswain
Copy link
Collaborator

kfswain commented Sep 10, 2025

Do we still need this pr?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2025
@zetxqx zetxqx marked this pull request as ready for review September 11, 2025 23:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Sep 11, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Sep 11, 2025

Do we still need this pr?

@kfswain thanks for reminding. Still need it for a stable conformance tests. I change the epp version to v1.0.0 for the conformance tests.

@robscott
Copy link
Member

/ok-to-test
/lgtm

Longer term this should probably be part of our release process (cc @danehans @kfswain @nirrozenbaum)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Sep 12, 2025

/retest

@kfswain
Copy link
Collaborator

kfswain commented Sep 16, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit a0cdd8b into kubernetes-sigs:main Sep 16, 2025
11 checks passed
@nirrozenbaum
Copy link
Contributor

@zetxqx can you open a follow up issue to make sure this field is updated in the release script?

@zetxqx
Copy link
Contributor Author

zetxqx commented Sep 17, 2025

@zetxqx can you open a follow up issue to make sure this field is updated in the release script?

created #1606

@zetxqx zetxqx deleted the fix1258 branch September 29, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use pinned tags in conformance tests

6 participants