Skip to content

cleanup: simplify endpointpickerconfig #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

capri-xiyue
Copy link
Contributor

@capri-xiyue capri-xiyue commented Aug 7, 2025

simplify endpointpickerconfig

Copy link

netlify bot commented Aug 7, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit e5e2ff3
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6894eacc300c470008195a08
😎 Deploy Preview https://deploy-preview-1324--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: capri-xiyue
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and danehans August 7, 2025 17:43
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @capri-xiyue. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 7, 2025
@capri-xiyue
Copy link
Contributor Author

capri-xiyue commented Aug 7, 2025

If we remove inline, I think we have to change the underlying crd. Another option is to remove the endpointerpick struct directly, see the updated PR #1324. However, Abdullah Gharaibeh mentioned If we are removing this struct, we may want to rename extensionRef to make it explicit that this is an epp extension? With renaming, the crd will also change.

To avoid break change to the crd, should we just skip the renaming? cc @robscott @ahg-g

@capri-xiyue capri-xiyue changed the title cleanup: remove inline of endpointpickerconfig cleanup: simplify endpointpickerconfig Aug 7, 2025
@liu-cong
Copy link
Contributor

liu-cong commented Aug 7, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants