-
Notifications
You must be signed in to change notification settings - Fork 135
cleanup: simplify endpointpickerconfig #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
cleanup: simplify endpointpickerconfig #1324
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: capri-xiyue The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @capri-xiyue. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
config/crd/bases/inference.networking.k8s.io_inferencepools.yaml
Outdated
Show resolved
Hide resolved
If we remove inline, I think we have to change the underlying crd. Another option is to remove the endpointerpick struct directly, see the updated PR #1324. However, Abdullah Gharaibeh mentioned If we are removing this struct, we may want to rename extensionRef to make it explicit that this is an epp extension? With renaming, the crd will also change. To avoid break change to the crd, should we just skip the renaming? cc @robscott @ahg-g |
/ok-to-test |
simplify endpointpickerconfig