Skip to content

fix: make port number become pointer #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 5 commits into from
Aug 18, 2025
Merged

fix: make port number become pointer #1400

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e664457
make port number become pointer
capri-xiyue Aug 18, 2025
af37ed1
fixed ut
capri-xiyue Aug 18, 2025
4dfb025
updated crd
capri-xiyue Aug 18, 2025
ede3698
change to use pointer
capri-xiyue Aug 18, 2025
f6367c6
changed comment
capri-xiyue Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion api/v1/inferencepool_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@ type Extension struct {
// Service.
//
// +optional
PortNumber PortNumber `json:"portNumber,omitempty"`
//nolint:kubeapilinter
// ignore kubeapilinter here as we want to use pointer here as 0 usually means all ports.
PortNumber *PortNumber `json:"portNumber,omitempty"`

// Configures how the gateway handles the case when the extension is not responsive.
// Defaults to failClose.
Expand Down
5 changes: 5 additions & 0 deletions api/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions apix/v1alpha2/inferencepool_conversion_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func TestInferencePoolConvertTo(t *testing.T) {
Group: &v1Group,
Kind: v1Kind,
Name: "my-epp-service",
PortNumber: v1PortNumber,
PortNumber: &v1PortNumber,
FailureMode: v1FailureMode,
},
},
Expand Down Expand Up @@ -239,7 +239,7 @@ func TestInferencePoolConvertFrom(t *testing.T) {
Group: &v1Group,
Kind: v1Kind,
Name: "my-epp-service",
PortNumber: v1PortNumber,
PortNumber: &v1PortNumber,
FailureMode: v1FailureMode,
},
},
Expand Down