Skip to content

Conversation

capri-xiyue
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
InferencePool.ExtensionRef.PortNumber should be a pointer and KIA doesn't apply here as 0 usually means all ports. Should not use 0 to indicate it is user not set.

Which issue(s) this PR fixes:

Fixes #1386

Does this PR introduce a user-facing change?:
None


@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 18, 2025
Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit f6367c6
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68a38e8db05cc7000882a0f7
😎 Deploy Preview https://deploy-preview-1400--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @capri-xiyue. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2025
@capri-xiyue
Copy link
Contributor Author

/assign @robscott

@capri-xiyue
Copy link
Contributor Author

/assign @kfswain

@capri-xiyue
Copy link
Contributor Author

/assign @JoelSpeed

@robscott
Copy link
Member

Thanks @capri-xiyue!

/lgtm

@robscott
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2025
@nirrozenbaum
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025
@kfswain
Copy link
Collaborator

kfswain commented Aug 18, 2025

looks good, will stamp when CI is passing

@danehans
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit dd6834a into kubernetes-sigs:main Aug 18, 2025
10 checks passed
//
// +optional
PortNumber PortNumber `json:"portNumber,omitempty"`
//nolint:kubeapilinter // ignore kubeapilinter here as we want to use pointer here as 0 usually means all ports.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a suboptimal way of excluding KAL on this field. It's preferable to exclude a single error message via the golangci-lint config directly.

That way you'll be able to still benefit from other issues that KAL reports on this field, without disabling linting for the field altogether.

The config is something like:

exclude_rules:
- text: "PortNumber does not have a valid zero value and does not need to be a pointer"
  path: api/v1/inferencepool_types.go

LiorLieberman referenced this pull request in istio/istio Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InferencePool: Finalize InferencePool.ExtensionRef.PortNumber

7 participants