-
Notifications
You must be signed in to change notification settings - Fork 182
fix: make port number become pointer #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make port number become pointer #1400
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @capri-xiyue. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @robscott |
/assign @kfswain |
/assign @JoelSpeed |
Thanks @capri-xiyue! /lgtm |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
looks good, will stamp when CI is passing |
/lgtm |
// | ||
// +optional | ||
PortNumber PortNumber `json:"portNumber,omitempty"` | ||
//nolint:kubeapilinter // ignore kubeapilinter here as we want to use pointer here as 0 usually means all ports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a suboptimal way of excluding KAL on this field. It's preferable to exclude a single error message via the golangci-lint config directly.
That way you'll be able to still benefit from other issues that KAL reports on this field, without disabling linting for the field altogether.
The config is something like:
exclude_rules:
- text: "PortNumber does not have a valid zero value and does not need to be a pointer"
path: api/v1/inferencepool_types.go
Signed-off-by: Daneyon Hansen <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
InferencePool.ExtensionRef.PortNumber should be a pointer and KIA doesn't apply here as 0 usually means all ports. Should not use 0 to indicate it is user not set.
Which issue(s) this PR fixes:
Fixes #1386
Does this PR introduce a user-facing change?:
None