Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/v1/inferencepool_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ type Extension struct {
// Service.
//
// +optional
PortNumber PortNumber `json:"portNumber,omitempty"`
//nolint:kubeapilinter // ignore kubeapilinter here as we want to use pointer here as 0 usually means all ports.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a suboptimal way of excluding KAL on this field. It's preferable to exclude a single error message via the golangci-lint config directly.

That way you'll be able to still benefit from other issues that KAL reports on this field, without disabling linting for the field altogether.

The config is something like:

exclude_rules:
- text: "PortNumber does not have a valid zero value and does not need to be a pointer"
  path: api/v1/inferencepool_types.go

PortNumber *PortNumber `json:"portNumber,omitempty"`

// Configures how the gateway handles the case when the extension is not responsive.
// Defaults to failClose.
Expand Down
5 changes: 5 additions & 0 deletions api/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions apix/v1alpha2/inferencepool_conversion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func TestInferencePoolConvertTo(t *testing.T) {
Group: &v1Group,
Kind: v1Kind,
Name: "my-epp-service",
PortNumber: v1PortNumber,
PortNumber: &v1PortNumber,
FailureMode: v1FailureMode,
},
},
Expand Down Expand Up @@ -239,7 +239,7 @@ func TestInferencePoolConvertFrom(t *testing.T) {
Group: &v1Group,
Kind: v1Kind,
Name: "my-epp-service",
PortNumber: v1PortNumber,
PortNumber: &v1PortNumber,
FailureMode: v1FailureMode,
},
},
Expand Down