Skip to content

Conversation

capri-xiyue
Copy link
Contributor

@capri-xiyue capri-xiyue commented Aug 20, 2025

What type of PR is this?

What this PR does / why we need it:
Rename the filed to make it more clear

Which issue(s) this PR fixes:

part of #1173
Fixes: #1326

Does this PR introduce a user-facing change?:

Users need to change the` extensionRef` to  `endpointPickerRef`

Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit c94e81d
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68a6319b6b17a00008d8f8bf
😎 Deploy Preview https://deploy-preview-1420--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 20, 2025
@capri-xiyue
Copy link
Contributor Author

/assign @kfswain

@danehans
Copy link
Contributor

xref #1421 for API docs.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 20, 2025
@capri-xiyue
Copy link
Contributor Author

xref #1421 for API docs.

Will do it in another PR as it is not directly related to this PR

@danehans
Copy link
Contributor

Will do it in another PR as it is not directly related to this PR

@kfswain will be pushing a fix.

@kfswain
Copy link
Collaborator

kfswain commented Aug 20, 2025

/approve

This looks good but would like to let: #1422 merge before we merge this, in case we want to update the docs

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2025
@danehans
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 16737b1 into kubernetes-sigs:main Aug 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up of EndpointPickerConfig

4 participants