fix api-ref-docs make target and generate result #1422
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Makefile
Outdated
| $(call go-install-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen,$(CONTROLLER_TOOLS_VERSION)) | ||
|
|
||
| .PHONY: crd-ref-docs | ||
| crd-ref-docs: $(CRD_REF_DOCS) ## Download setup-envtest locally if necessary. |
There was a problem hiding this comment.
@kfswain can you fix the target docs since ^ will show up in make help?
|
Can you re-generate the docs after #1420 merges? |
|
I don't see the /lgtm |
k8s-ci-robot
added
the
lgtm
Yup! Was handling other things to give time for that PR to merge, but we can update at release time also, nbd |
3 participants
What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
Fixes: #1421