Skip to content

Conversation

srampal
Copy link
Contributor

@srampal srampal commented Aug 28, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##711

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kfswain August 28, 2025 19:23
@k8s-ci-robot
Copy link
Contributor

Welcome @srampal!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @srampal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2025
@srampal srampal changed the title Add BBR docs WIP: Add BBR docs Aug 28, 2025
Copy link

netlify bot commented Aug 28, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit f0823dd
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c9d9b2478aeb0008c4e881
😎 Deploy Preview https://deploy-preview-1498--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Sep 10, 2025

/ok-to-test

Thanks for starting this, any planned progress on it?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2025
@srampal
Copy link
Contributor Author

srampal commented Sep 10, 2025

/ok-to-test

Thanks for starting this, any planned progress on it?

Yes, I am working on it based on the v1.0.0 release that just came out. There are already some doc updates on BBR added and I will add some more in the next few days.

@srampal srampal force-pushed the bbr-docs branch 3 times, most recently from ef93eea to 14b4788 Compare September 11, 2025 07:40
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2025
@srampal srampal marked this pull request as ready for review September 11, 2025 07:43
@srampal
Copy link
Contributor Author

srampal commented Sep 11, 2025

@ahg-g @kfswain this is ready for review now. I could add some more (such as using BBR to directly route to a standalone LLM service as the BackendRef instead of to an InferencePool/EPP) but maybe those and other potential scenarios could be added in a followup PR to let this one get merged for now. cc @keithmattix @davidbreitgand

@srampal srampal changed the title WIP: Add BBR docs Add BBR docs, example deployment Sep 11, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2025
@srampal srampal force-pushed the bbr-docs branch 4 times, most recently from f1a34ab to d878235 Compare September 11, 2025 08:23
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 16, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Sep 16, 2025

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, srampal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2025
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 16, 2025
@srampal srampal marked this pull request as draft September 16, 2025 21:31
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2025
@ahg-g ahg-g removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2025
@srampal srampal marked this pull request as ready for review September 16, 2025 21:42
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g September 16, 2025 21:42
@kfswain
Copy link
Collaborator

kfswain commented Sep 16, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit df77f01 into kubernetes-sigs:main Sep 16, 2025
9 checks passed
@srampal srampal deleted the bbr-docs branch September 18, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants