-
Notifications
You must be signed in to change notification settings - Fork 182
fix(deps): update prometheus/common to v0.66.1 and prometheus/client_golang to v1.23.1 #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/lgtm waiting for tests to pass before final stamp. Thanks @JeffLuoo! |
Checking the test failure.. |
The test failure is related to the newly introduced validation in the new version of the library. All metrics-related tests need to be updated as well. |
…golang to v1.23.1
923cee5
to
6885e23
Compare
Also need to bump github.com/prometheus/client_golang to 1.23.1. Updated it and tested it locally. |
/lgtm Thanks @JeffLuoo! 🙏🏼 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeffLuoo, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
#1546
Does this PR introduce a user-facing change?:
Test it on my cluster, no crashing.