Skip to content

Conversation

JeffLuoo
Copy link
Contributor

@JeffLuoo JeffLuoo commented Sep 12, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

#1546

Does this PR introduce a user-facing change?:

NONE

Test it on my cluster, no crashing.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2025
@JeffLuoo
Copy link
Contributor Author

@ahg-g

Copy link

netlify bot commented Sep 12, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 6885e23
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c8170f79af6100084c802d
😎 Deploy Preview https://deploy-preview-1580--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nirrozenbaum
Copy link
Contributor

/lgtm

waiting for tests to pass before final stamp.

Thanks @JeffLuoo!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2025
@JeffLuoo
Copy link
Contributor Author

Checking the test failure..

@JeffLuoo
Copy link
Contributor Author

The test failure is related to the newly introduced validation in the new version of the library. All metrics-related tests need to be updated as well.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2025
@JeffLuoo
Copy link
Contributor Author

JeffLuoo commented Sep 15, 2025

Also need to bump github.com/prometheus/client_golang to 1.23.1. Updated it and tested it locally.

@JeffLuoo JeffLuoo changed the title fix(deps): update prometheus/common to v0.66.1 fix(deps): update prometheus/common to v0.66.1 and prometheus/client_golang to v1.23.1 Sep 15, 2025
@nirrozenbaum
Copy link
Contributor

/lgtm
/approve

Thanks @JeffLuoo! 🙏🏼

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeffLuoo, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 959d33e into kubernetes-sigs:main Sep 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants