Rename PodInfo struct to EndpointMetadata to better reflect its purpose

pkg/epp/backend/metrics/fake.go

@@ -38,18 +38,18 @@ type FakePodMetrics struct {
 }
 
 func (fpm *FakePodMetrics) String() string {
-	return fmt.Sprintf("Pod: %v; Metrics: %v", fpm.GetPod(), fpm.GetMetrics())
+	return fmt.Sprintf("Pod: %v; Metrics: %v", fpm.GetMetadata(), fpm.GetMetrics())
 }
 
-func (fpm *FakePodMetrics) GetPod() *backend.Pod {
+func (fpm *FakePodMetrics) GetMetadata() *backend.Pod {
 	return fpm.Pod
 }
 
 func (fpm *FakePodMetrics) GetMetrics() *MetricsState {
 	return fpm.Metrics
 }
 
-func (fpm *FakePodMetrics) UpdatePod(pod *datalayer.PodInfo) {
+func (fpm *FakePodMetrics) UpdateMetadata(pod *datalayer.EndpointMetadata) {
 	fpm.Pod = pod
 }
 func (fpm *FakePodMetrics) GetAttributes() *datalayer.Attributes {

pkg/epp/backend/metrics/pod_metrics.go

@@ -53,18 +53,18 @@ type PodMetricsClient interface {
 }
 
 func (pm *podMetrics) String() string {
-	return fmt.Sprintf("Pod: %v; Metrics: %v", pm.GetPod(), pm.GetMetrics())
+	return fmt.Sprintf("Pod: %v; Metrics: %v", pm.GetMetadata(), pm.GetMetrics())
 }
 
-func (pm *podMetrics) GetPod() *backend.Pod {
+func (pm *podMetrics) GetMetadata() *backend.Pod {
 	return pm.pod.Load()
 }
 
 func (pm *podMetrics) GetMetrics() *MetricsState {
 	return pm.metrics.Load()
 }
 
-func (pm *podMetrics) UpdatePod(pod *datalayer.PodInfo) {
+func (pm *podMetrics) UpdateMetadata(pod *datalayer.EndpointMetadata) {
 	pm.pod.Store(pod)
 }
 
@@ -73,7 +73,7 @@ func (pm *podMetrics) UpdatePod(pod *datalayer.PodInfo) {
 func (pm *podMetrics) startRefreshLoop(ctx context.Context) {
 	pm.startOnce.Do(func() {
 		go func() {
-			pm.logger.V(logutil.DEFAULT).Info("Starting refresher", "pod", pm.GetPod())
+			pm.logger.V(logutil.DEFAULT).Info("Starting refresher", "pod", pm.GetMetadata())
 			ticker := time.NewTicker(pm.interval)
 			defer ticker.Stop()
 			for {
@@ -84,7 +84,7 @@ func (pm *podMetrics) startRefreshLoop(ctx context.Context) {
 					return
 				case <-ticker.C: // refresh metrics periodically
 					if err := pm.refreshMetrics(); err != nil {
-						pm.logger.V(logutil.TRACE).Error(err, "Failed to refresh metrics", "pod", pm.GetPod())
+						pm.logger.V(logutil.TRACE).Error(err, "Failed to refresh metrics", "pod", pm.GetMetadata())
 					}
 				}
 			}
@@ -95,7 +95,7 @@ func (pm *podMetrics) startRefreshLoop(ctx context.Context) {
 func (pm *podMetrics) refreshMetrics() error {
 	ctx, cancel := context.WithTimeout(context.Background(), fetchMetricsTimeout)
 	defer cancel()
-	updated, err := pm.pmc.FetchMetrics(ctx, pm.GetPod(), pm.GetMetrics())
+	updated, err := pm.pmc.FetchMetrics(ctx, pm.GetMetadata(), pm.GetMetrics())
 	if err != nil {
 		pm.logger.V(logutil.TRACE).Info("Failed to refreshed metrics:", "err", err)
 	}
@@ -115,7 +115,7 @@ func (pm *podMetrics) refreshMetrics() error {
 }
 
 func (pm *podMetrics) stopRefreshLoop() {
-	pm.logger.V(logutil.DEFAULT).Info("Stopping refresher", "pod", pm.GetPod())
+	pm.logger.V(logutil.DEFAULT).Info("Stopping refresher", "pod", pm.GetMetadata())
 	pm.stopOnce.Do(func() {
 		close(pm.done)
 	})

pkg/epp/backend/metrics/pod_metrics_test.go

@@ -30,7 +30,7 @@ import (
 )
 
 var (
-	pod1Info = &datalayer.PodInfo{
+	pod1Info = &datalayer.EndpointMetadata{
 		NamespacedName: types.NamespacedName{
 			Name:      "pod1-rank-0",
 			Namespace: "default",

pkg/epp/backend/metrics/types.go

@@ -52,7 +52,7 @@ type PodMetricsFactory struct {
 	refreshMetricsInterval time.Duration
 }
 
-func (f *PodMetricsFactory) NewEndpoint(parentCtx context.Context, pod *datalayer.PodInfo, ds datalayer.PoolInfo) PodMetrics {
+func (f *PodMetricsFactory) NewEndpoint(parentCtx context.Context, pod *datalayer.EndpointMetadata, ds datalayer.PoolInfo) PodMetrics {
 	pm := &podMetrics{
 		pmc:       f.pmc,
 		ds:        ds,

pkg/epp/backend/pod.go

@@ -20,4 +20,4 @@ import (
 	"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/datalayer"
 )
 
-type Pod = datalayer.PodInfo
+type Pod = datalayer.EndpointMetadata

pkg/epp/controller/inferencepool_reconciler_test.go

@@ -121,7 +121,7 @@ func TestInferencePoolReconciler(t *testing.T) {
 	if _, err := inferencePoolReconciler.Reconcile(ctx, req); err != nil {
 		t.Errorf("Unexpected InferencePool reconcile error: %v", err)
 	}
-	if diff := diffStore(ds, diffStoreParams{wantPool: pool1, wantPods: []string{"pod1-rank-0", "pod2-rank-0"}}); diff != "" {
+	if diff := diffStore(ds, diffStoreParams{wantPool: pool1, wantEndpoints: []string{"pod1-rank-0", "pod2-rank-0"}}); diff != "" {
 		t.Errorf("Unexpected diff (+got/-want): %s", diff)
 	}
 
@@ -139,7 +139,7 @@ func TestInferencePoolReconciler(t *testing.T) {
 	if _, err := inferencePoolReconciler.Reconcile(ctx, req); err != nil {
 		t.Errorf("Unexpected InferencePool reconcile error: %v", err)
 	}
-	if diff := diffStore(ds, diffStoreParams{wantPool: newPool1, wantPods: []string{"pod5-rank-0"}}); diff != "" {
+	if diff := diffStore(ds, diffStoreParams{wantPool: newPool1, wantEndpoints: []string{"pod5-rank-0"}}); diff != "" {
 		t.Errorf("Unexpected diff (+got/-want): %s", diff)
 	}
 
@@ -154,7 +154,7 @@ func TestInferencePoolReconciler(t *testing.T) {
 	if _, err := inferencePoolReconciler.Reconcile(ctx, req); err != nil {
 		t.Errorf("Unexpected InferencePool reconcile error: %v", err)
 	}
-	if diff := diffStore(ds, diffStoreParams{wantPool: newPool1, wantPods: []string{"pod5-rank-0"}}); diff != "" {
+	if diff := diffStore(ds, diffStoreParams{wantPool: newPool1, wantEndpoints: []string{"pod5-rank-0"}}); diff != "" {
 		t.Errorf("Unexpected diff (+got/-want): %s", diff)
 	}
 
@@ -168,14 +168,14 @@ func TestInferencePoolReconciler(t *testing.T) {
 	if _, err := inferencePoolReconciler.Reconcile(ctx, req); err != nil {
 		t.Errorf("Unexpected InferencePool reconcile error: %v", err)
 	}
-	if diff := diffStore(ds, diffStoreParams{wantPods: []string{}}); diff != "" {
+	if diff := diffStore(ds, diffStoreParams{wantEndpoints: []string{}}); diff != "" {
 		t.Errorf("Unexpected diff (+got/-want): %s", diff)
 	}
 }
 
 type diffStoreParams struct {
 	wantPool       *v1.InferencePool
-	wantPods       []string
+	wantEndpoints  []string
 	wantObjectives []*v1alpha2.InferenceObjective
 }
 
@@ -188,15 +188,15 @@ func diffStore(datastore datastore.Datastore, params diffStoreParams) string {
 	}
 
 	// Default wantPods if not set because PodGetAll returns an empty slice when empty.
-	if params.wantPods == nil {
-		params.wantPods = []string{}
+	if params.wantEndpoints == nil {
+		params.wantEndpoints = []string{}
 	}
-	gotPods := []string{}
-	for _, pm := range datastore.PodList(backendmetrics.AllPodsPredicate) {
-		gotPods = append(gotPods, pm.GetPod().NamespacedName.Name)
+	gotEndpoints := []string{}
+	for _, em := range datastore.PodList(backendmetrics.AllPodsPredicate) {
+		gotEndpoints = append(gotEndpoints, em.GetMetadata().NamespacedName.Name)
 	}
-	if diff := cmp.Diff(params.wantPods, gotPods, cmpopts.SortSlices(func(a, b string) bool { return a < b })); diff != "" {
-		return "pods:" + diff
+	if diff := cmp.Diff(params.wantEndpoints, gotEndpoints, cmpopts.SortSlices(func(a, b string) bool { return a < b })); diff != "" {
+		return "endpoints:" + diff
 	}
 
 	// Default wantModels if not set because ModelGetAll returns an empty slice when empty.
@@ -348,8 +348,8 @@ func xDiffStore(t *testing.T, datastore datastore.Datastore, params xDiffStorePa
 		params.wantPods = []string{}
 	}
 	gotPods := []string{}
-	for _, pm := range datastore.PodList(backendmetrics.AllPodsPredicate) {
-		gotPods = append(gotPods, pm.GetPod().NamespacedName.Name)
+	for _, em := range datastore.PodList(backendmetrics.AllPodsPredicate) {
+		gotPods = append(gotPods, em.GetMetadata().NamespacedName.Name)
 	}
 	if diff := cmp.Diff(params.wantPods, gotPods, cmpopts.SortSlices(func(a, b string) bool { return a < b })); diff != "" {
 		return "pods:" + diff

pkg/epp/controller/pod_reconciler_test.go

@@ -212,8 +212,8 @@ func TestPodReconciler(t *testing.T) {
 			}
 
 			var gotPods []*corev1.Pod
-			for _, pm := range store.PodList(backendmetrics.AllPodsPredicate) {
-				pod := &corev1.Pod{ObjectMeta: metav1.ObjectMeta{Name: pm.GetPod().PodName, Namespace: pm.GetPod().NamespacedName.Namespace}, Status: corev1.PodStatus{PodIP: pm.GetPod().GetIPAddress()}}
+			for _, em := range store.PodList(backendmetrics.AllPodsPredicate) {
+				pod := &corev1.Pod{ObjectMeta: metav1.ObjectMeta{Name: em.GetMetadata().PodName, Namespace: em.GetMetadata().NamespacedName.Namespace}, Status: corev1.PodStatus{PodIP: em.GetMetadata().GetIPAddress()}}
 				gotPods = append(gotPods, pod)
 			}
 			if !cmp.Equal(gotPods, test.wantPods, cmpopts.SortSlices(func(a, b *corev1.Pod) bool { return a.Name < b.Name })) {

pkg/epp/datalayer/collector.go

@@ -88,7 +88,7 @@ func (c *Collector) Start(ctx context.Context, ticker Ticker, ep Endpoint, sourc
 	started := false
 
 	c.startOnce.Do(func() {
-		logger := log.FromContext(ctx).WithValues("endpoint", ep.GetPod().GetIPAddress())
+		logger := log.FromContext(ctx).WithValues("endpoint", ep.GetMetadata().GetIPAddress())
 		c.ctx, c.cancel = context.WithCancel(ctx)
 		started = true
 		ready = make(chan struct{})

pkg/epp/datalayer/collector_test.go

@@ -44,14 +44,14 @@ func (d *DummySource) Collect(ctx context.Context, ep Endpoint) error {
 }
 
 func defaultEndpoint() Endpoint {
-	pod := &PodInfo{
+	meta := &EndpointMetadata{
 		NamespacedName: types.NamespacedName{
 			Name:      "pod-name",
 			Namespace: "default",
 		},
 		Address: "1.2.3.4:5678",
 	}
-	ms := NewEndpoint(pod, nil)
+	ms := NewEndpoint(meta, nil)
 	return ms
 }
 

pkg/epp/datalayer/endpoint.go

@@ -21,10 +21,10 @@ import (
 	"sync/atomic"
 )
 
-// EndpointPodState allows management of the Pod related attributes.
-type EndpointPodState interface {
-	GetPod() *PodInfo
-	UpdatePod(*PodInfo)
+// EndpointMetaState allows management of the EndpointMetadata related attributes.
+type EndpointMetaState interface {
+	GetMetadata() *EndpointMetadata
+	UpdateMetadata(*EndpointMetadata)
 	GetAttributes() *Attributes
 }
 
@@ -37,45 +37,45 @@ type EndpointMetricsState interface {
 // Endpoint represents an inference serving endpoint and its related attributes.
 type Endpoint interface {
 	fmt.Stringer
-	EndpointPodState
+	EndpointMetaState
 	EndpointMetricsState
 	AttributeMap
 }
 
 // ModelServer is an implementation of the Endpoint interface.
 type ModelServer struct {
-	pod        atomic.Pointer[PodInfo]
+	pod        atomic.Pointer[EndpointMetadata]
 	metrics    atomic.Pointer[Metrics]
 	attributes *Attributes
 }
 
-// NewEndpoint returns a new ModelServer with the given PodInfo and Metrics.
-func NewEndpoint(pod *PodInfo, metrics *Metrics) *ModelServer {
-	if pod == nil {
-		pod = &PodInfo{}
+// NewEndpoint returns a new ModelServer with the given EndpointMetadata and Metrics.
+func NewEndpoint(meta *EndpointMetadata, metrics *Metrics) *ModelServer {
+	if meta == nil {
+		meta = &EndpointMetadata{}
 	}
 	if metrics == nil {
 		metrics = NewMetrics()
 	}
 	ep := &ModelServer{
 		attributes: NewAttributes(),
 	}
-	ep.UpdatePod(pod)
+	ep.UpdateMetadata(meta)
 	ep.UpdateMetrics(metrics)
 	return ep
 }
 
 // String returns a representation of the ModelServer. For brevity, only names of
 // extended attributes are returned and not their values.
 func (srv *ModelServer) String() string {
-	return fmt.Sprintf("Pod: %v; Metrics: %v; Attributes: %v", srv.GetPod(), srv.GetMetrics(), srv.Keys())
+	return fmt.Sprintf("Pod: %v; Metrics: %v; Attributes: %v", srv.GetMetadata(), srv.GetMetrics(), srv.Keys())
 }
 
-func (srv *ModelServer) GetPod() *PodInfo {
+func (srv *ModelServer) GetMetadata() *EndpointMetadata {
 	return srv.pod.Load()
 }
 
-func (srv *ModelServer) UpdatePod(pod *PodInfo) {
+func (srv *ModelServer) UpdateMetadata(pod *EndpointMetadata) {
 	srv.pod.Store(pod)
 }
 

pkg/epp/datalayer/podinfo.go → pkg/epp/datalayer/endpoint_metadata.go

@@ -30,8 +30,8 @@ type Addressable interface {
 	GetNamespacedName() types.NamespacedName
 }
 
-// PodInfo represents the relevant Kubernetes Pod state of an inference server.
-type PodInfo struct {
+// EndpointMetadata represents the relevant Kubernetes Pod state of an inference server.
+type EndpointMetadata struct {
 	NamespacedName types.NamespacedName
 	PodName        string
 	Address        string
@@ -40,16 +40,16 @@ type PodInfo struct {
 	Labels         map[string]string
 }
 
-// String returns a string representation of the pod.
-func (p *PodInfo) String() string {
-	if p == nil {
+// String returns a string representation of the endpoint.
+func (e *EndpointMetadata) String() string {
+	if e == nil {
 		return ""
 	}
-	return fmt.Sprintf("%+v", *p)
+	return fmt.Sprintf("%+v", *e)
 }
 
 // Clone returns a full copy of the object.
-func (p *PodInfo) Clone() *PodInfo {
+func (p *EndpointMetadata) Clone() *EndpointMetadata {
 	if p == nil {
 		return nil
 	}
@@ -58,7 +58,7 @@ func (p *PodInfo) Clone() *PodInfo {
 	for key, value := range p.Labels {
 		clonedLabels[key] = value
 	}
-	return &PodInfo{
+	return &EndpointMetadata{
 		NamespacedName: types.NamespacedName{
 			Name:      p.NamespacedName.Name,
 			Namespace: p.NamespacedName.Namespace,
@@ -71,22 +71,22 @@ func (p *PodInfo) Clone() *PodInfo {
 	}
 }
 
-// GetNamespacedName gets the namespace name of the Pod.
-func (p *PodInfo) GetNamespacedName() types.NamespacedName {
-	return p.NamespacedName
+// GetNamespacedName gets the namespace name of the Endpoint.
+func (e *EndpointMetadata) GetNamespacedName() types.NamespacedName {
+	return e.NamespacedName
 }
 
-// GetIPAddress returns the Pod's IP address.
-func (p *PodInfo) GetIPAddress() string {
-	return p.Address
+// GetIPAddress returns the Endpoint's IP address.
+func (e *EndpointMetadata) GetIPAddress() string {
+	return e.Address
 }
 
-// GetPort returns the Pod's inference port.
-func (p *PodInfo) GetPort() string {
-	return p.Port
+// GetPort returns the Endpoint's inference port.
+func (e *EndpointMetadata) GetPort() string {
+	return e.Port
 }
 
-// GetMetricsHost returns the pod's metrics host (ip:port)
-func (p *PodInfo) GetMetricsHost() string {
-	return p.MetricsHost
+// GetMetricsHost returns the Endpoint's metrics host (ip:port)
+func (e *EndpointMetadata) GetMetricsHost() string {
+	return e.MetricsHost
 }