Add conversion webhook for v1 #947

imreddy13 · 2025-07-22T22:46:37Z

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

netlify · 2025-07-22T22:46:42Z

✅ Deploy Preview for kubernetes-sigs-jobset ready!

Name	Link
🔨 Latest commit	`8f2f5a2`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-jobset/deploys/688014cf5bd74600086e11cd
😎 Deploy Preview	https://deploy-preview-947--kubernetes-sigs-jobset.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2025-07-22T22:46:43Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: imreddy13
Once this PR has been reviewed and has the lgtm label, please assign kannon92 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-07-22T22:46:47Z

Hi @imreddy13. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kannon92 · 2025-07-23T01:47:55Z

/ok-to-test

kannon92 · 2025-07-23T01:48:13Z

api/jobset/v1/doc.go

@@ -0,0 +1,21 @@
+/*
+Copyright 2023 The Kubernetes Authors.


Suggested change

Copyright 2023 The Kubernetes Authors.

Copyright 2025 The Kubernetes Authors.

kannon92 · 2025-07-23T01:49:10Z

api/jobset/v1/jobset_types.go

@@ -0,0 +1,420 @@
+/*


cc @andreyvelich

Thank you for driving this @imreddy13!
Can we discuss all of the breaking changes to the JobSet APIs before introducing the V1 please ?

I feel like we have a few open discussions that we need to resolve before the v1, for example:

Remove StartupPolicy API in favour of DependsOn

Rename JobSet status to Complete #723

Make ReplicatedJobs a custom resource with their own controller #946

cc @ahg-g @tenzen-y @Electronic-Waste @astefanutti

#946 Would involve a significant refactor/rewrite of much of the codebase, so it could probably wait til v2 as @GiuseppeTT pointed out.

Shall we consider to have v1alpha2 API before the v1 API to deprecate several APIs ?

cc @danielvegamyhre for visibility

That makes sense.
My only recommendation is that we maintain consistency across JobSet status fields.
Which means if we maintain ReplicatedJobsStatus field, keep the IndividualJobsStatus field, where we define:

type IndividualJobStatus struct { Name string `json:"name"` Recreates int32 `json:"recreates"` }

I agree with that. @carreter would you be up for making that change?

I think we can do this in v1alpha2 since we did not yet release this change.

I agree with that. @carreter would you be up for making that change?

Sure, I'll take a stab at it! Makes sense to try and keep it consistent.

kannon92 · 2025-07-23T02:28:03Z

/hold

You mentioned this is still a draft offline.

kannon92 · 2025-07-23T02:29:24Z

cc @tchap @ardaguclu

I mentioned this work to you all so just wanted you to be aware.

k8s-triage-robot · 2025-12-14T17:27:12Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-ci-robot · 2025-12-18T03:51:43Z

@imreddy13: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-jobset-test-integration-main	`8f2f5a2`	link	true	`/test pull-jobset-test-integration-main`
pull-jobset-verify-main	`8f2f5a2`	link	true	`/test pull-jobset-verify-main`
pull-jobset-test-e2e-main-1-32	`8f2f5a2`	link	true	`/test pull-jobset-test-e2e-main-1-32`
pull-jobset-test-e2e-main-1-31	`8f2f5a2`	link	true	`/test pull-jobset-test-e2e-main-1-31`
pull-jobset-test-unit-main	`8f2f5a2`	link	true	`/test pull-jobset-test-unit-main`
pull-jobset-test-e2e-main-1-33	`8f2f5a2`	link	true	`/test pull-jobset-test-e2e-main-1-33`
pull-jobset-test-e2e-main-1-34	`8f2f5a2`	link	true	`/test pull-jobset-test-e2e-main-1-34`
pull-jobset-test-e2e-main-1-35	`8f2f5a2`	link	true	`/test pull-jobset-test-e2e-main-1-35`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-triage-robot · 2026-01-17T03:55:18Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Add conversion webhook for v1

8f2f5a2

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2025

k8s-ci-robot requested review from danielvegamyhre and kannon92 July 22, 2025 22:46

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2025

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 22, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2025

kannon92 reviewed Jul 23, 2025

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2025

This was referenced Jul 25, 2025

chore(api): Remove Deprecated StartupPolicy API #956

Open

Release 0.9 Roadmap #865

Closed

carreter mentioned this pull request Jul 28, 2025

Change IndividualJobRecreates to IndividualJobStatus.Recreates #958

Merged

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 17, 2026

	Copyright 2023 The Kubernetes Authors.
	Copyright 2025 The Kubernetes Authors.

Add conversion webhook for v1 #947

Are you sure you want to change the base?

Add conversion webhook for v1 #947

Conversation

imreddy13 commented Jul 22, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

netlify bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-jobset ready!

Uh oh!

k8s-ci-robot commented Jul 22, 2025

Uh oh!

k8s-ci-robot commented Jul 22, 2025

Uh oh!

kannon92 commented Jul 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carreter Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kannon92 commented Jul 23, 2025

Uh oh!

kannon92 commented Jul 23, 2025

Uh oh!

k8s-triage-robot commented Dec 14, 2025

Uh oh!

k8s-ci-robot commented Dec 18, 2025

Uh oh!

k8s-triage-robot commented Jan 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

netlify bot commented Jul 22, 2025 •

edited

Loading

carreter Jul 23, 2025 •

edited

Loading