Skip to content

Change IndividualJobRecreates to IndividualJobStatus.Recreates #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 8 commits into from
Aug 4, 2025
Merged

Change IndividualJobRecreates to IndividualJobStatus.Recreates #958

k8s-ci-robot merged 8 commits into from
Aug 4, 2025

Conversation

@carreter
Copy link
Contributor

@carreter carreter commented Jul 28, 2025

What type of PR is this?

/kind api-change

What this PR does / why we need it:

See discussion over at #947 (comment)

This makes IndividualJobStatus to be consistent with ReplicatedJobsStatus.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Change how individual job recreates are stored to be consistent with ReplicatedJobStatus

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2025
@netlify
Copy link

netlify bot commented Jul 28, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit eea6369
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-jobset/deploys/68910503083d8d0008378cea

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 28, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 28, 2025

Hi @carreter. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@carreter carreter marked this pull request as ready for review July 28, 2025 19:44
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 28, 2025
@k8s-ci-robot k8s-ci-robot requested a review from kannon92 July 28, 2025 19:45
@carreter carreter mentioned this pull request Jul 28, 2025
Open
@kannon92
Copy link
Contributor

kannon92 commented Jul 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 28, 2025
@GiuseppeTT
Copy link
Contributor

GiuseppeTT commented Jul 28, 2025

@kannon92 Do you mind if I also review this one? : )

@kannon92
Copy link
Contributor

kannon92 commented Jul 28, 2025

@kannon92 Do you mind if I also review this one? : )

Your input is always encouraged!

@kannon92
Copy link
Contributor

kannon92 commented Jul 28, 2025

/assign @GiuseppeTT

GiuseppeTT
GiuseppeTT reviewed Jul 28, 2025
View reviewed changes
GiuseppeTT
GiuseppeTT reviewed Jul 29, 2025
View reviewed changes
Copy link
Contributor

@GiuseppeTT GiuseppeTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@GiuseppeTT
Copy link
Contributor

GiuseppeTT commented Jul 29, 2025

/assign @andreyvelich

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025
@carreter
Copy link
Contributor Author

carreter commented Jul 30, 2025

Thanks for updating the API @carreter! Do we want to add some unit tests to the failure_policy_test.go ?

Currently failure_policy_test.go has no unit tests at all for the failure policy actions themselves, just the logic that finds the first matching failed job. I'm happy to add the unit tests in a separate PR! Let me know if this is desired and I will create an issue for it.

@carreter
Copy link
Contributor Author

carreter commented Jul 30, 2025

Whoops, forgot to regenerate the CRDs. 1sec

@andreyvelich
Copy link
Member

andreyvelich commented Jul 30, 2025

Let me know if this is desired and I will create an issue for it.

Sure, that would be fantastic! Thank you!

@carreter carreter mentioned this pull request Jul 30, 2025
Closed
@carreter carreter requested a review from andreyvelich July 31, 2025 22:18
@carreter carreter mentioned this pull request Jul 31, 2025
Merged
kannon92
kannon92 reviewed Aug 3, 2025
View reviewed changes
@kannon92 kannon92 moved this to In Progress in Code to Review Aug 3, 2025
@kannon92 kannon92 moved this from In Progress to PR has requested changes in Code to Review Aug 3, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2025
@carreter carreter requested a review from kannon92 August 4, 2025 19:09
carreter added a commit to carreter/jobset that referenced this pull request Aug 4, 2025
@carreter
rebase on top of kubernetes-sigs#958
516e95a
kannon92
kannon92 approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'll leave final lgtm to @GiuseppeTT or @andreyvelich.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carreter, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025
@GiuseppeTT
Copy link
Contributor

GiuseppeTT commented Aug 4, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit c79e4fd into kubernetes-sigs:main Aug 4, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from PR has requested changes to Done in Code to Review Aug 4, 2025
carreter added a commit to carreter/jobset that referenced this pull request Aug 4, 2025
@carreter
Rebase on top of kubernetes-sigs#958
5a6323b
k8s-ci-robot pushed a commit that referenced this pull request Aug 11, 2025
@carreter
Add FailurePolicyAction unit tests (#967)
a4da72d 
* Add FailurePolicyAction unit tests

* Rebase on top of #958

* Typo

* Remove unecessary test parameter
@kannon92 kannon92 added this to the v0.9.0 milestone Aug 17, 2025
@GiuseppeTT GiuseppeTT mentioned this pull request Jan 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 kannon92 approved these changes

@GiuseppeTT GiuseppeTT Awaiting requested review from GiuseppeTT

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

Assignees

@andreyvelich andreyvelich

@GiuseppeTT GiuseppeTT

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

Code to Review
Status: Done

Milestone

v0.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@carreter @k8s-ci-robot @kannon92 @GiuseppeTT @andreyvelich