-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor: Replace HTTP status code literal with constant #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor: Replace HTTP status code literal with constant #192
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
=======================================
Coverage 51.49% 51.49%
=======================================
Files 56 56
Lines 8417 8417
=======================================
Hits 4334 4334
Misses 3850 3850
Partials 233 233 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thank you very much for contributing @vatsalm1611 |
|
great, could you please squash your changes into a single commit? |
9f76a32 to
c48d3da
Compare
|
Commits squashed as requested. Let me know if anything else is needed. Thanks! |
chore: remove verbose comment from import
6bff13f to
76adcec
Compare
|
Hi, |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
|
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Description
Replaced the hardcoded
"404"status code literal with the standardhttp.StatusNotFoundconstant in status code checks.String matching for error messages (e.g.,
strings.Contains(errStr, "404")) is intentionally left as-is, since many cloud APIs return error codes as strings in error messages.Fixes #191
Type of change
Testing
helm lintand template validation)Checklist
Additional context
No additional context.