Skip to content

Conversation

@vatsalm1611
Copy link

Description

Replaced the hardcoded "404" status code literal with the standard http.StatusNotFound constant in status code checks.
String matching for error messages (e.g., strings.Contains(errStr, "404")) is intentionally left as-is, since many cloud APIs return error codes as strings in error messages.

Fixes #191

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Helm chart change
  • Other (please describe)

Testing

  • Tested changes manually
  • Unit tests added/updated
  • Helm chart tests pass (helm lint and template validation)
  • Added examples for new features

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated the relevant CRDs if needed
  • I have updated the Helm chart version if needed
  • I have added tests that prove my fix is effective or that my feature works

Additional context

No additional context.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.49%. Comparing base (8eda21d) to head (c84548a).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cloudprovider/ibm/client.go 0.00% 12 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   51.49%   51.49%           
=======================================
  Files          56       56           
  Lines        8417     8417           
=======================================
  Hits         4334     4334           
  Misses       3850     3850           
  Partials      233      233           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pfeifferj
Copy link
Member

thank you very much for contributing @vatsalm1611
I left one little comment

@pfeifferj
Copy link
Member

great, could you please squash your changes into a single commit?

@vatsalm1611 vatsalm1611 force-pushed the fix-http-status-literals branch from 9f76a32 to c48d3da Compare August 8, 2025 05:45
@vatsalm1611
Copy link
Author

Commits squashed as requested. Let me know if anything else is needed. Thanks!

chore: remove verbose comment from import
@vatsalm1611 vatsalm1611 force-pushed the fix-http-status-literals branch from 6bff13f to 76adcec Compare August 8, 2025 10:37
@vatsalm1611
Copy link
Author

Hi,
I realized after squashing that commits should be GPG signed as well, so I have now amended and force-pushed a signed commit.
Let me know if everything looks good now or if you need anything else from my side. Thanks!

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pfeifferj
Copy link
Member

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFE] HTTP Status Code Literals

5 participants