Skip to content

Refactor: Replace HTTP status code literal with constant #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −14
Open

Refactor: Replace HTTP status code literal with constant #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76adcec
Refactor: Replace HTTP status code literal with constant
vatsalm1611 Aug 6, 2025
c84548a
Merge branch 'main' into fix-http-status-literals
vatsalm1611 Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions pkg/cloudprovider/ibm/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"fmt"
"os"
"time"
"net/http"
)

// Client represents an IBM Cloud API client
Expand Down Expand Up @@ -127,23 +128,23 @@ func (c *Client) VPCInstanceExists(ctx context.Context, instanceID string) (bool
return true, nil
}

// containsNotFoundError checks if an error indicates a resource was not found
func containsNotFoundError(err error) bool {
if err == nil {
return false
}

errStr := err.Error()
// Check for common "not found" error patterns from IBM Cloud VPC API
return containsAnyString(errStr, []string{
"not found",
"404",
"Not Found",
"does not exist",
"cannot be found",
})
if err == nil {
return false
}

errStr := err.Error()
// Check for common "not found" error patterns from IBM Cloud VPC API
return containsAnyString(errStr, []string{
"not found",
fmt.Sprintf("%d", http.StatusNotFound), // 404
"Not Found",
"does not exist",
"cannot be found",
})
}


// containsAnyString checks if a string contains any of the specified substrings
func containsAnyString(s string, substrings []string) bool {
for _, substring := range substrings {
Expand Down
Loading