-
Notifications
You must be signed in to change notification settings - Fork 39
Updating MIC and MBSC definitions #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating MIC and MBSC definitions #1044
Conversation
MIC and MBSC objects should be namespaced, since they are the direct derivitive of the Module object
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @ybettan |
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
- Coverage 79.09% 74.37% -4.72%
==========================================
Files 51 76 +25
Lines 5109 6705 +1596
==========================================
+ Hits 4041 4987 +946
- Misses 882 1510 +628
- Partials 186 208 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // +kubebuilder:subresource:status | ||
| //+kubebuilder:object:root=true | ||
| //+kubebuilder:subresource:status | ||
| //+kubebuilder:resource:scope=Namespaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already namespaced
| // +kubebuilder:resource:path=moduleimagesconfigs,scope=Namespaced,shortName=mic |
| // +kubebuilder:subresource:status | ||
| //+kubebuilder:object:root=true | ||
| //+kubebuilder:subresource:status | ||
| //+kubebuilder:resource:scope=Namespaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already namespaced
| // +kubebuilder:resource:path=modulebuildsignconfigs,scope=Namespaced,shortName=mbsc |
MIC and MBSC objects should be namespaced, since they are the direct derivitive of the Module object