Skip to content

Updating MIC and MBSC definitions #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yevgeny-shnaidman wants to merge 1 commit into from
Closed

Updating MIC and MBSC definitions #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions api/v1beta1/modulebuildsignconfig_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,9 @@ type ModuleBuildSignConfigStatus struct {
Images []BuildSignImageState `json:"images"`
}

// +kubebuilder:object:root=true
// +kubebuilder:subresource:status
//+kubebuilder:object:root=true
//+kubebuilder:subresource:status
//+kubebuilder:resource:scope=Namespaced
Copy link
Contributor

@ybettan ybettan Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already namespaced

kernel-module-management/api/v1beta1/modulebuildsignconfig_types.go

Line 81 in ef3e317

// +kubebuilder:resource:path=modulebuildsignconfigs,scope=Namespaced,shortName=mbsc


// ModuleBuildSignConfig keeps the request for images' build/sign for a KMM Module.
// +kubebuilder:resource:path=modulebuildsignconfigs,scope=Namespaced,shortName=mbsc
Expand All @@ -88,7 +89,7 @@ type ModuleBuildSignConfig struct {
Status ModuleBuildSignConfigStatus `json:"status,omitempty"`
}

// +kubebuilder:object:root=true
//+kubebuilder:object:root=true

// ModuleBuildSignConfigList is a list of ModuleBuildSignConfig objects.
type ModuleBuildSignConfigList struct {
Expand Down
5 changes: 3 additions & 2 deletions api/v1beta1/moduleimagesconfig_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,9 @@ type ModuleImagesConfigStatus struct {
ImagesStates []ModuleImageState `json:"imagesStates"`
}

// +kubebuilder:object:root=true
// +kubebuilder:subresource:status
//+kubebuilder:object:root=true
//+kubebuilder:subresource:status
//+kubebuilder:resource:scope=Namespaced
Copy link
Contributor

@ybettan ybettan Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already namespaced

kernel-module-management/api/v1beta1/moduleimagesconfig_types.go

Line 87 in ef3e317

// +kubebuilder:resource:path=moduleimagesconfigs,scope=Namespaced,shortName=mic


// ModuleImagesConfig keeps the request for images' state for a KMM Module.
// +kubebuilder:resource:path=moduleimagesconfigs,scope=Namespaced,shortName=mic
Expand Down
Loading