chore: bump to go 1.24 #5920
chore: bump to go 1.24 #5920
Conversation
Signed-off-by: Tyler Auerbeck <[email protected]>
…pt current lints before bump to v2 Signed-off-by: Tyler Auerbeck <[email protected]>
|
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tylerauerbeck The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @tylerauerbeck. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/XL
There was a problem hiding this comment.
Hi @tylerauerbeck
Thanks for you help to bump go version!
I added a review comments, Please split changes like chore, refactor, or golangci-lint upgrades into separate PRs and merge those first!
| @@ -1,6 +1,6 @@ | |||
| module sigs.k8s.io/kustomize/api | |||
|
|
|||
| go 1.22.7 | |||
| go 1.24.3 | |||
There was a problem hiding this comment.
Please change to go 1.24.0 tag in go.mod file.
details: #5763 (comment)
However, for the Go runtime versions actually used like Dockerfiles or GitHub Actions, newer patch versions are safe to use, so always use the latest available version whenever possible.
| @@ -169,7 +169,7 @@ func (fl *FileLoader) New(path string) (ifc.Loader, error) { | |||
| } | |||
| root, err := filesys.ConfirmDir(fl.fSys, fl.root.Join(path)) | |||
| if err != nil { | |||
| return nil, errors.WrapPrefixf(err, ErrRtNotDir.Error()) //nolint:govet | |||
There was a problem hiding this comment.
Could you update the go runtime version in this PR while keeping only the minimum necessary changes to pass existing tests and lint checks? If needed, we could extract the lint-related changes in this PR into a separate PR and merge that one first.
By keeping the go version bump PR simple, we'll make it easy to revert in case of any issues during upgrade.
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @tylerauerbeck |
Per conversation in #5915 , it's desired to bump all modules/packages to v1.24 prior to upgrading
golangci-lintto v2.This PR in turn does the following:
nolintto applicable lints which will be addressed in upgrade to v2