chore: bump to go 1.24

.golangci.yml

@@ -3,7 +3,7 @@
 
 run:
   deadline: 5m
-  go: '1.22'
+  go: '1.24'
 
 linters:
   enable-all: true

api/filters/replacement/replacement.go

@@ -199,14 +199,17 @@ func copyValueToTarget(target *yaml.RNode, value *yaml.RNode, selector *types.Ta
 			Path:   kyaml_utils.SmarterPathSplitter(fp, "."),
 			Create: createKind})
 		if err != nil {
-			return errors.WrapPrefixf(err, fieldRetrievalError(fp, createKind != 0)) //nolint:govet
+			msg := fieldRetrievalError(fp, createKind != 0)
+			return errors.WrapPrefixf(err, "%s", msg)
 		}
 		targetFields, err := targetFieldList.Elements()
 		if err != nil {
-			return errors.WrapPrefixf(err, fieldRetrievalError(fp, createKind != 0)) //nolint:govet
+			msg := fieldRetrievalError(fp, createKind != 0)
+			return errors.WrapPrefixf(err, "%s", msg)
 		}
 		if len(targetFields) == 0 {
-			return errors.Errorf(fieldRetrievalError(fp, createKind != 0)) //nolint:govet
+			msg := fieldRetrievalError(fp, createKind != 0)
+			return errors.Errorf("%s", msg)
 		}
 
 		for _, t := range targetFields {

api/go.mod

@@ -1,6 +1,6 @@
 module sigs.k8s.io/kustomize/api
 
-go 1.22.7
+go 1.24.3
 
 require (
 	github.com/blang/semver/v4 v4.0.0

api/internal/git/repospec_test.go

@@ -693,7 +693,7 @@ func TestNewRepoSpecFromUrl_Smoke(t *testing.T) {
 			rs.Dir = ""
 			rs.Submodules = false
 			rs.Timeout = 0
-			assert.Equal(t, &tc.repoSpec, rs) //nolint:gosec
+			assert.Equal(t, &tc.repoSpec, rs)
 		})
 	}
 }

api/internal/loader/fileloader.go

@@ -169,7 +169,7 @@ func (fl *FileLoader) New(path string) (ifc.Loader, error) {
 	}
 	root, err := filesys.ConfirmDir(fl.fSys, fl.root.Join(path))
 	if err != nil {
-		return nil, errors.WrapPrefixf(err, ErrRtNotDir.Error()) //nolint:govet
+		return nil, errors.WrapPrefixf(err, "%s", ErrRtNotDir.Error())
 	}
 	if err = fl.errIfGitContainmentViolation(root); err != nil {
 		return nil, err

api/internal/loader/fileloader_test.go

@@ -54,7 +54,6 @@ func TestIsRemoteFile(t *testing.T) {
 		},
 	}
 	for name, test := range cases {
-		test := test
 		t.Run(name, func(t *testing.T) {
 			require.Equal(t, test.valid, IsRemoteFile(test.url))
 		})

api/internal/loader/loader.go

@@ -28,7 +28,7 @@ func NewLoader(
 	}
 	root, err := filesys.ConfirmDir(fSys, target)
 	if err != nil {
-		return nil, errors.WrapPrefixf(err, ErrRtNotDir.Error()) //nolint:govet
+		return nil, errors.WrapPrefixf(err, "%s", ErrRtNotDir.Error())
 	}
 	return newLoaderAtConfirmedDir(
 		lr, root, fSys, nil, git.ClonerUsingGitExec), nil

api/internal/localizer/locloader_test.go

@@ -84,7 +84,6 @@ func TestNewLocLoaderDefaultForRootTarget(t *testing.T) {
 		},
 	}
 	for name, params := range cases {
-		params := params
 		t.Run(name, func(t *testing.T) {
 			req := require.New(t)
 			fSys := makeMemoryFs(t)
@@ -172,7 +171,6 @@ func TestNewLocLoaderCwdNotRoot(t *testing.T) {
 	}
 
 	for name, test := range cases {
-		test := test
 		t.Run(name, func(t *testing.T) {
 			req := require.New(t)
 			fSys := makeWdFs(t)[test.wd]
@@ -223,7 +221,6 @@ func TestNewLocLoaderFails(t *testing.T) {
 		},
 	}
 	for name, params := range cases {
-		params := params
 		t.Run(name, func(t *testing.T) {
 			var buf bytes.Buffer
 			log.SetOutput(&buf)
@@ -254,7 +251,6 @@ func TestNewFails(t *testing.T) {
 		"file":              "delta/deployment.yaml",
 	}
 	for name, root := range cases {
-		root := root
 		t.Run(name, func(t *testing.T) {
 			fSys := makeMemoryFs(t)
 
@@ -283,7 +279,6 @@ func TestLoadFails(t *testing.T) {
 		"winding inside dst": "/a/test/../newDir/pod.yaml",
 	}
 	for name, file := range cases {
-		file := file
 		t.Run(name, func(t *testing.T) {
 			req := require.New(t)
 			fSys := makeMemoryFs(t)

api/internal/plugins/builtinconfig/transformerconfig_test.go

@@ -154,7 +154,7 @@ func TestMakeDefaultConfig_mutation(t *testing.T) {
 }
 
 func BenchmarkMakeDefaultConfig(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for i := 0; i < b.N; i++ { //nolint:intrange
 		_ = MakeDefaultConfig()
 	}
 }

api/internal/plugins/execplugin/execplugin.go

@@ -162,13 +162,15 @@ func (p *ExecPlugin) invokePlugin(input []byte) ([]byte, error) {
 	}
 	_, err = f.Write(p.cfg)
 	if err != nil {
+		msg := fmt.Sprintf("writing plugin config to %s", f.Name())
 		return nil, errors.WrapPrefixf(
-			err, "writing plugin config to "+f.Name())
+			err, "%s", msg)
 	}
 	err = f.Close()
 	if err != nil {
+		msg := fmt.Sprintf("closing plugin config file %s", f.Name())
 		return nil, errors.WrapPrefixf(
-			err, "closing plugin config file "+f.Name())
+			err, "%s", msg)
 	}
 	//nolint:gosec
 	cmd := exec.Command(
@@ -182,10 +184,9 @@ func (p *ExecPlugin) invokePlugin(input []byte) ([]byte, error) {
 	}
 	result, err := cmd.Output()
 	if err != nil {
-		//nolint:govet
 		return nil, errors.WrapPrefixf(
 			fmt.Errorf("failure in plugin configured via %s; %w",
-				f.Name(), err), stdErr.String())
+				f.Name(), err), "%s", stdErr.String())
 	}
 	return result, os.Remove(f.Name())
 }

api/krusty/remoteloader_test.go

@@ -53,8 +53,7 @@ func TestRemoteLoad_LocalProtocol(t *testing.T) {
 		}
 		root := t.TempDir()
 
-		hashPath, err := os.MkdirTemp(root, "hash-")
-		require.NoError(t, err)
+		hashPath := t.TempDir()
 		hashDir := filepath.Base(hashPath)
 
 		bash(fmt.Sprintf(`
@@ -437,7 +436,7 @@ func configureGitSSHCommand(t *testing.T) {
 	require.NoError(t, err)
 
 	// Write the key to a temp file and use it in SSH
-	f, err := os.CreateTemp("", "kustomize_ssh")
+	f, err := os.CreateTemp(t.TempDir(), "kustomize_ssh")
 	require.NoError(t, err)
 	_, err = io.Copy(f, bytes.NewReader(key))
 	require.NoError(t, err)

api/resource/resource_test.go

@@ -339,7 +339,7 @@ metadata:
 `))
 	require.NoError(t, err)
 
-	for i := 0; i < patchApplyCount; i++ {
+	for i := 0; i < patchApplyCount; i++ { //nolint: intrange
 		require.NoError(t, resource.ApplySmPatch(noOpPatch))
 
 		bytes, err := resource.AsYAML()

api/testutils/kusttest/harnessenhanced.go

@@ -57,13 +57,11 @@ func MakeEnhancedHarness(t *testing.T) *HarnessEnhanced {
 
 func MakeEnhancedHarnessWithTmpRoot(t *testing.T) *HarnessEnhanced {
 	t.Helper()
+	var err error
 	r := makeBaseEnhancedHarness(t)
 	fSys := filesys.MakeFsOnDisk()
 	r.Harness = MakeHarnessWithFs(t, fSys)
-	tmpDir, err := os.MkdirTemp("", "kust-testing-")
-	if err != nil {
-		panic("test harness cannot make tmp dir: " + err.Error())
-	}
+	tmpDir := t.TempDir()
 	r.ldr, err = fLdr.NewLoader(fLdr.RestrictionRootOnly, tmpDir, fSys)
 	if err != nil {
 		panic("test harness cannot make ldr at tmp dir: " + err.Error())

api/testutils/localizertest/filesystem.go

@@ -58,10 +58,10 @@ func SetWorkingDir(t *testing.T, workingDir string) {
 	wd, err := os.Getwd()
 	require.NoError(t, err)
 	t.Cleanup(func() {
-		require.NoError(t, os.Chdir(wd))
+		require.NoError(t, os.Chdir(wd)) //nolint:usetesting
 	})
 
-	err = os.Chdir(workingDir)
+	err = os.Chdir(workingDir) //nolint:usetesting
 	require.NoError(t, err)
 }
 

cmd/config/docs/api-conventions/functions-impl.md

@@ -90,7 +90,7 @@ End-of-message
 image.
 
 ```
-FROM public.ecr.aws/docker/library/golang:1.22.7-bullseye
+FROM public.ecr.aws/docker/library/golang:1.24.3-bullseye
 RUN go get sigs.k8s.io/kustomize/cmd/config
 RUN mv /go/bin/config /usr/bin/config
 COPY nginx-template.sh /usr/bin/nginx-template.sh

cmd/config/go.mod

@@ -1,6 +1,6 @@
 module sigs.k8s.io/kustomize/cmd/config
 
-go 1.22.7
+go 1.24.3
 
 require (
 	github.com/go-errors/errors v1.4.2

cmd/config/internal/commands/cat_test.go

@@ -354,7 +354,7 @@ spec:
 		return
 	}
 
-	f, err := os.CreateTemp("", "kustomize-cat-test-dest")
+	f, err := os.CreateTemp(t.TempDir(), "kustomize-cat-test-dest")
 	if !assert.NoError(t, err) {
 		return
 	}

cmd/config/internal/commands/e2e/e2e_test.go

@@ -507,10 +507,7 @@ metadata:
 				t.Skip()
 			}
 
-			dir, err := os.MkdirTemp("", "kustomize-test-data-")
-			if !assert.NoError(t, err) {
-				t.FailNow()
-			}
+			dir := t.TempDir()
 			defer os.RemoveAll(dir)
 			os.Chdir(dir)
 
@@ -528,7 +525,7 @@ metadata:
 			cmd.Stderr = &stdErr
 			cmd.Env = os.Environ()
 
-			err = cmd.Run()
+			err := cmd.Run()
 			if tt.expectedErr != "" {
 				if !assert.Contains(t, stdErr.String(), tt.expectedErr, stdErr.String()) {
 					t.FailNow()

cmd/config/internal/commands/e2e/e2econtainerconfig/Dockerfile

@@ -1,7 +1,7 @@
 # Copyright 2019 The Kubernetes Authors.
 # SPDX-License-Identifier: Apache-2.0
 
-FROM public.ecr.aws/docker/library/golang:1.22.7-bullseye
+FROM public.ecr.aws/docker/library/golang:1.24.3-bullseye
 ENV CGO_ENABLED=0
 WORKDIR /go/src/
 

cmd/config/internal/commands/e2e/e2econtainerconfig/go.mod

@@ -1,6 +1,6 @@
 module sigs.k8s.io/kustomize/cmd/config/internal/commands/e2e/e2econtainerconfig
 
-go 1.22.7
+go 1.24.3
 
 require sigs.k8s.io/kustomize/kyaml v0.14.2
 

cmd/config/internal/commands/e2e/e2econtainerenvgenerator/Dockerfile

@@ -1,7 +1,7 @@
 # Copyright 2019 The Kubernetes Authors.
 # SPDX-License-Identifier: Apache-2.0
 
-FROM public.ecr.aws/docker/library/golang:1.22.7-bullseye
+FROM public.ecr.aws/docker/library/golang:1.24.3-bullseye
 ENV CGO_ENABLED=0
 WORKDIR /go/src/
 

cmd/config/internal/commands/e2e/e2econtainerenvgenerator/go.mod

@@ -1,6 +1,6 @@
 module sigs.k8s.io/kustomize/cmd/config/internal/commands/e2e/e2econtainerenvgenerator
 
-go 1.22.7
+go 1.24.3
 
 require sigs.k8s.io/kustomize/kyaml v0.14.2
 

cmd/config/internal/commands/e2e/e2econtainermountbind/Dockerfile

@@ -1,7 +1,7 @@
 # Copyright 2019 The Kubernetes Authors.
 # SPDX-License-Identifier: Apache-2.0
 
-FROM public.ecr.aws/docker/library/golang:1.22.7-bullseye
+FROM public.ecr.aws/docker/library/golang:1.24.3-bullseye
 ENV CGO_ENABLED=0
 WORKDIR /go/src/
 

cmd/config/internal/commands/e2e/e2econtainermountbind/go.mod

@@ -1,6 +1,6 @@
 module sigs.k8s.io/kustomize/cmd/config/internal/commands/e2e/e2econtainer-render-helm-chart
 
-go 1.22.7
+go 1.24.3
 
 require sigs.k8s.io/kustomize/kyaml v0.14.2
 

cmd/config/internal/commands/e2e/e2econtainersimplegenerator/Dockerfile

@@ -1,7 +1,7 @@
 # Copyright 2019 The Kubernetes Authors.
 # SPDX-License-Identifier: Apache-2.0
 
-FROM public.ecr.aws/docker/library/golang:1.22.7-bullseye
+FROM public.ecr.aws/docker/library/golang:1.24.3-bullseye
 ENV CGO_ENABLED=0
 WORKDIR /go/src/
 

cmd/config/internal/commands/e2e/e2econtainersimplegenerator/go.mod

@@ -1,6 +1,6 @@
 module sigs.k8s.io/kustomize/cmd/config/internal/commands/e2e/e2econtainersimplegenerator
 
-go 1.22.7
+go 1.24.3
 
 require sigs.k8s.io/kustomize/kyaml v0.14.2
 

cmd/config/internal/commands/e2e/test_util_test.go

@@ -42,10 +42,7 @@ func runTests(t *testing.T, tests []test) {
 	for i := range tests {
 		tt := tests[i]
 		t.Run(tt.name, func(t *testing.T) {
-			dataDir, err := os.MkdirTemp("", "kustomize-test-data-")
-			if !assert.NoError(t, err) {
-				t.FailNow()
-			}
+			dataDir := t.TempDir()
 			defer os.RemoveAll(dataDir)
 			os.Chdir(dataDir)
 
@@ -62,7 +59,7 @@ func runTests(t *testing.T, tests []test) {
 			cmd.Stderr = &stdErr
 			cmd.Env = os.Environ()
 
-			err = cmd.Run()
+			err := cmd.Run()
 			if tt.expectedErr != "" {
 				if !assert.Contains(t, stdErr.String(), tt.expectedErr, stdErr.String()) {
 					t.FailNow()

cmd/config/internal/commands/grep.go

@@ -102,7 +102,7 @@ func (r *GrepRunner) preRunE(c *cobra.Command, args []string) error {
 		r.Value = last[1]
 	}
 
-	r.Path = append(parts[:len(parts)-1], last[0]) //nolint:gocritic
+	r.GrepFilter.Path = append(parts[:len(parts)-1], last[0]) //nolint:gocritic
 	return nil
 }