Skip to content

Use the right path for falling back to nssm #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

Use the right path for falling back to nssm #511

merged 2 commits into from
Aug 19, 2025

Conversation

zylxjtu
Copy link
Contributor

@zylxjtu zylxjtu commented Aug 15, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 15, 2025
@zylxjtu
Copy link
Contributor Author

zylxjtu commented Aug 15, 2025

/assign @marosset

marosset
marosset reviewed Aug 18, 2025
View reviewed changes
capz/templates/gmsa-ci.yaml Outdated
@@ -108,7 +108,7 @@ spec:
& $scriptPath
} else {
Write-Host "RestartKubelet.ps1 not found. Running fallback command..."
nssm set kubelet start SERVICE_AUTO_START
& "$env:SYSTEMDRIVE\k\nssm" set kubelet start SERVICE_AUTO_START
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add .exe at the end of the path too so since this is running in powershell?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@marosset
Copy link
Contributor

/approve
I can /lgtm after the template get re-built

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, zylxjtu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@marosset
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 18, 2025
@marosset
Copy link
Contributor

/hold
it looks like provisioning is failing for the test job

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

@zylxjtu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-capz-windows-2025-extension b6a1c5b link false /test pull-e2e-capz-windows-2025-extension

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@marosset
Copy link
Contributor

/hold cancel
/lgtm
tests are passing

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7ae1778 into kubernetes-sigs:master Aug 19, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marosset marosset marosset left review comments

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zylxjtu @marosset @k8s-ci-robot