Skip to content

Use the right path for falling back to nssm #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

Use the right path for falling back to nssm #511

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ea955b
Use the right path for falling back to nssm
zylxjtu Aug 15, 2025
b6a1c5b
Address the comment
zylxjtu Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion capz/templates/gmsa-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ spec:
& $scriptPath
} else {
Write-Host "RestartKubelet.ps1 not found. Running fallback command..."
nssm set kubelet start SERVICE_AUTO_START
& "$env:SYSTEMDRIVE\k\nssm" set kubelet start SERVICE_AUTO_START
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add .exe at the end of the path too so since this is running in powershell?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

}
path: C:/KubeletRestart_nssm_sc.ps1
permissions: "0744"
Expand Down
2 changes: 1 addition & 1 deletion capz/templates/gmsa-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ spec:
& $scriptPath
} else {
Write-Host "RestartKubelet.ps1 not found. Running fallback command..."
nssm set kubelet start SERVICE_AUTO_START
& "$env:SYSTEMDRIVE\k\nssm" set kubelet start SERVICE_AUTO_START
}
path: C:/KubeletRestart_nssm_sc.ps1
permissions: "0744"
Expand Down
2 changes: 1 addition & 1 deletion capz/templates/shared-image-gallery-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ spec:
& $scriptPath
} else {
Write-Host "RestartKubelet.ps1 not found. Running fallback command..."
nssm set kubelet start SERVICE_AUTO_START
& "$env:SYSTEMDRIVE\k\nssm" set kubelet start SERVICE_AUTO_START
}
path: C:/KubeletRestart_nssm_sc.ps1
permissions: "0744"
Expand Down
2 changes: 1 addition & 1 deletion capz/templates/windows-base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ spec:
& $scriptPath
} else {
Write-Host "RestartKubelet.ps1 not found. Running fallback command..."
nssm set kubelet start SERVICE_AUTO_START
& "$env:SYSTEMDRIVE\k\nssm" set kubelet start SERVICE_AUTO_START
}
path: C:/KubeletRestart_nssm_sc.ps1
permissions: "0744"
Expand Down
2 changes: 1 addition & 1 deletion capz/templates/windows-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ spec:
& $scriptPath
} else {
Write-Host "RestartKubelet.ps1 not found. Running fallback command..."
nssm set kubelet start SERVICE_AUTO_START
& "$env:SYSTEMDRIVE\k\nssm" set kubelet start SERVICE_AUTO_START
}
path: C:/KubeletRestart_nssm_sc.ps1
permissions: "0744"
Expand Down
2 changes: 1 addition & 1 deletion capz/templates/windows-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ spec:
& $scriptPath
} else {
Write-Host "RestartKubelet.ps1 not found. Running fallback command..."
nssm set kubelet start SERVICE_AUTO_START
& "$env:SYSTEMDRIVE\k\nssm" set kubelet start SERVICE_AUTO_START
}
path: C:/KubeletRestart_nssm_sc.ps1
permissions: "0744"
Expand Down
Loading