azure: enable testing with LTS on AKS #8722
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/cluster-autoscaler
area/provider/azure
| tier: ${AKS_TIER:=Standard} | ||
| supportPlan: ${AKS_SUPPORT_PLAN:=KubernetesOfficial} |
There was a problem hiding this comment.
These are the current defaults, though we could make tier: Premium and supportPlan: AKSLongTermSupport the defaults (or even hardcode them) here. That would cost more money, but we wouldn't need to manage which versions require LTS and which don't as that set evolves over time. Only preview versions (currently 1.34.0) can't be created with AKSLongTermSupport, but even newer Kubernetes versions (1.31-1.33) can.
There was a problem hiding this comment.
I like this, we can update the test-infra job to override. We can do this right now, as the job against PRs to master uses 1.33. Stand by...
There was a problem hiding this comment.
kubernetes/test-infra#35826 should be back-compat (so not breaking other PRs in flight against master) but enable us to test this change here before we merge
|
/assign @jackfrancis |
|
Unit test failure:
Looks like this is a flake? /retest |
|
Testing kubernetes/test-infra#35826: /test pull-cluster-autoscaler-e2e-azure-master |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@jackfrancis Could you please summon the cherry pick bot as necessary? |
|
/cherry-pick cluster-autoscaler-release-1.30 |
|
@jackfrancis: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: new pull request created: #8724 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick cluster-autoscaler-release-1.31 |
|
@jackfrancis: new pull request created: #8725 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: new pull request created: #8726 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: new pull request created: #8727 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: new pull request created: #8728 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds the necessary parameters to the AKS cluster built for Azure cluster-autoscaler tests to enable testing on LTS versions of Kubernetes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: