Skip to content

azure: enable testing with LTS on AKS #8722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

azure: enable testing with LTS on AKS #8722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../cloudprovider/azure/test/templates/cluster-template-prow-aks-aso-cluster-autoscaler.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ spec:
enabled: true
servicePrincipalProfile:
clientId: msi
sku:
name: Base
tier: ${AKS_TIER:=Standard}
supportPlan: ${AKS_SUPPORT_PLAN:=KubernetesOfficial}
Comment on lines +54 to +55
Copy link
Contributor Author

@nojnhuh nojnhuh Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the current defaults, though we could make tier: Premium and supportPlan: AKSLongTermSupport the defaults (or even hardcode them) here. That would cost more money, but we wouldn't need to manage which versions require LTS and which don't as that set evolves over time. Only preview versions (currently 1.34.0) can't be created with AKSLongTermSupport, but even newer Kubernetes versions (1.31-1.33) can.

Copy link
Contributor

@jackfrancis jackfrancis Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, we can update the test-infra job to override. We can do this right now, as the job against PRs to master uses 1.33. Stand by...

Copy link
Contributor

@jackfrancis jackfrancis Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes/test-infra#35826 should be back-compat (so not breaking other PRs in flight against master) but enable us to test this change here before we merge

tags:
buildProvenance: ${BUILD_PROVENANCE}
creationTimestamp: ${TIMESTAMP}
Expand Down
Loading