Skip to content

Fix: Minor bugs in OCI Provider #8837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Minor bugs in OCI Provider #8837

wants to merge 2 commits into from
+24 −0

Conversation

@lxuan94-pp
Copy link

@lxuan94-pp lxuan94-pp commented Nov 20, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

To prevent oci autoscaler from crash due to bugs

Which issue(s) this PR fixes:

Fixes #

  • Autoscaler should not try to monitor or scale virtual nodes and virtual node pools
  • Enable IMDS to avoid specifying OCI_REGION_METADATA

Special notes for your reviewer:

The change has bee deployed in our team production for months without issues

Does this PR introduce a user-facing change?

None

Fix bugs in OCI provider

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

Hi @lxuan94-pp. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/cluster-autoscaler area/provider/oci Issues or PRs related to oci provider size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-area labels Nov 20, 2025
jackfrancis
jackfrancis requested changes Nov 20, 2025
View reviewed changes
cluster-autoscaler/cloudprovider/oci/nodepools/consts/annotations.go Outdated
// EphemeralStorageSize is the freeform tag key that would be used to determine the ephemeral-storage size of the node
EphemeralStorageSize = "cluster-autoscaler/node-ephemeral-storage"

// OciNodePoolResourceIdent is the string identifier in the ocid that indicates the resource is a virtual node pool
Copy link
Contributor

@jackfrancis jackfrancis Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using the wrong comment string here should be // OciVirtualNodeResourceIdent ...

Copy link
Author

@lxuan94-pp lxuan94-pp Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, corrected

Copy link
Author

@lxuan94-pp lxuan94-pp Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly request another review of #8543, which has been open for two months

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lxuan94-pp
Once this PR has been reviewed and has the lgtm label, please assign jlamillan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis requested changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@jlamillan jlamillan Awaiting requested review from jlamillan

Assignees

No one assigned

Labels

area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider area/provider/oci Issues or PRs related to oci provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lxuan94-pp @k8s-ci-robot @jackfrancis