Skip to content

go.mod: pinning go version to use patch from build env #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

go.mod: pinning go version to use patch from build env #1282

merged 1 commit into from
Oct 24, 2025
+2 −2

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Oct 22, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind design

What this PR does / why we need it:

Pinning go patch version (x.y.0) to use the available in the build environment.

This approach follows practice of kubernetes/kubernetes project, as well contributes to downstream projects to keep compatibility when not following the same build environment used by this project.

This PR is intentionally not updating the Go image from Dockerfile to prevent bumping dependencies with existing version.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

As per Slack discussion: https://kubernetes.slack.com/archives/C0LRMHZ1T/p1761150650682839

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 22, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dims October 22, 2025 18:13
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from kmala October 22, 2025 18:14
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Oct 22, 2025

DNS resolution while initializing build env of some doc tests, retrying individually:
/test netlify

@k8s-ci-robot
Copy link
Contributor

@mtulio: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cloud-provider-aws-check

/test pull-cloud-provider-aws-e2e

/test pull-cloud-provider-aws-test

The following commands are available to trigger optional jobs:

/test pull-cloud-provider-aws-e2e-kubetest2

/test pull-cloud-provider-aws-e2e-kubetest2-quick

Use /test all to run all jobs.

In response to this:

DNS resolution while initializing build env of some doc tests, retrying individually:
/test netlify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mtulio
Copy link
Contributor Author

mtulio commented Oct 22, 2025

/test pull-cloud-provider-aws-e2e-kubetest2

@mtulio
Copy link
Contributor Author

mtulio commented Oct 22, 2025 •
edited
Loading

Having unrelated issues in the e2e-kubetest2 (non build issues). This PR is ready for review.

/assign @kmala @elmiko

@kmala
Copy link
Member

kmala commented Oct 22, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Oct 23, 2025

/retest-required

@damdo
Copy link
Member

damdo commented Oct 23, 2025

Do we need a retest here?

@mtulio
Copy link
Contributor Author

mtulio commented Oct 23, 2025

/retest

@mtulio
Copy link
Contributor Author

mtulio commented Oct 23, 2025 •
edited
Loading

aws-e2e-kubetest2-quick is now passing.

WRT the docs builds, looks like Netlify was suffering outage yesterday ( https://www.netlifystatus.com/ ) that would be related with the build issue reported (unable to setup env / install python). Unrelated with this change. The /retest didn't triggered it.

Hey @elmiko @JoelSpeed , would you mind taking a look here, please?

damdo
damdo reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@JoelSpeed
Copy link
Contributor

@mtulio Any thoughts on how we can prevent this from being non-zero in the future?

@elmiko
Copy link
Contributor

elmiko commented Oct 24, 2025

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Oct 24, 2025

Hold to answer Joel's question and try some experiment in CI step.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Oct 24, 2025

@mtulio Any thoughts on how we can prevent this from being non-zero in the future?

Considering this is a kube practice, we could have something more broadly, maybe a shared test/lint inherited from k/k repo?

For now, I would suggest, at least for in-project check, to validate the go.mod in a CI step. Considering Github Actions/workflows is enabled here, we could use something like this:

If you think it would be something to consider, please leave comments in the 1283. I am unblocking this for now.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025
@damdo
Copy link
Member

damdo commented Oct 24, 2025 •
edited
Loading

@JoelSpeed good question. In Cluster API Provider AWS/GCP we are adopting the approach recommended by k/k and core Cluster API (here and here). See:

I think we can adopt the same approach here.

@damdo
Copy link
Member

damdo commented Oct 24, 2025

^ cc. @mtulio I think reusing something "standardized" by other projects could be more beneficial than rolling our own check

@mtulio
Copy link
Contributor Author

mtulio commented Oct 24, 2025

^ cc. @mtulio I think reusing something "standardized" by other projects could be more beneficial than rolling our own check

Good idea, I updated the PR with this option. Keeping there as draft to hear more thoughts.

@mtulio
Copy link
Contributor Author

mtulio commented Oct 24, 2025

I am investigating how to trigger rebuild in the Netlify jobs as those arent updating on PR changes.

@mtulio
go.mod: pinning go version to use patch from build env
d909bb6 
Pin Go patch version (`x.y.0`) to use the available in the build environment.

This approach follows practice of kubernetes/kubernetes project, as well
helps downstream projects to keep compatibility.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2025
@kmala
Copy link
Member

kmala commented Oct 24, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced Oct 24, 2025
Open
Draft
@mtulio
Copy link
Contributor Author

mtulio commented Oct 24, 2025

/test pull-cloud-provider-aws-e2e-kubetest2-quick

@k8s-ci-robot
Copy link
Contributor

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-aws-e2e-kubetest2-quick d909bb6 link false /test pull-cloud-provider-aws-e2e-kubetest2-quick
pull-cloud-provider-aws-e2e-kubetest2 d909bb6 link false /test pull-cloud-provider-aws-e2e-kubetest2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented Oct 24, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit bea9adf into kubernetes:master Oct 24, 2025
11 of 13 checks passed
@mtulio mtulio deleted the pin-gomod branch October 24, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@kmala kmala Awaiting requested review from kmala

1 more reviewer

@damdo damdo damdo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@damdo damdo

@kmala kmala

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mtulio @k8s-ci-robot @kmala @damdo @JoelSpeed @elmiko