-
Couldn't load subscription status.
- Fork 353
ci/gomod: added CI validation to prevent changing patch version of Go from non-zero #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8ed2bf8 to
b01b3e5
Compare
|
/test all |
8c065f9 to
d0421f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense to me
Introduce the step to validate if the go.mod is in conformance with Kubernetes project standard by using the patch version from the build env (ending with .0, x.y.0).
d0421f5 to
7f33f89
Compare
|
/test pull-cloud-provider-aws-check |
| gomod-dotzero-check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: "Checkout Repository" | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| show-progress: false | ||
| - name: "tests/e2e/go.mod must use Go version major.minor.0" | ||
| env: | ||
| GO_MOD_FILE: go.mod | ||
| run: | | ||
| test $(grep "^go " $GO_MOD_FILE | awk '{print $2}' | cut -d. -f3) != 0 && exit 1 | ||
| - name: "tests/e2e/go.mod must use Go version major.minor.0" | ||
| env: | ||
| GO_MOD_FILE: tests/e2e/go.mod | ||
| run: | | ||
| test $(grep "^go " $GO_MOD_FILE | awk '{print $2}' | cut -d. -f3) != 0 && exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to drop this in favour of if the make check. As its passing as a presubmit should already be mandatory for PRs right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being able to run the same checks locally would be very helpful, and then running that same check in an action gives us continual testing of that
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Introduce the step to validate if the go.mod is in conformance with Kubernetes project standard by using the patch version from the build env (ending with .0, x.y.0).
This PR presents two options:
Please leave a comment with your thoughts of which option would be ok to follow the practice by this project.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: