Skip to content

ci/gomod: added CI validation to prevent changing patch version of Go from non-zero #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −1
Open

ci/gomod: added CI validation to prevent changing patch version of Go from non-zero #1283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,13 @@ jobs:
uses: golang/govulncheck-action@v1
with:
go-version-file: tests/e2e/go.mod
gomod-dotzero-check:
runs-on: ubuntu-latest
steps:
- name: "Checkout Repository"
uses: actions/checkout@v4
with:
show-progress: false
- name: "Go directive must use Go version major.minor.0"
run: |
make verify-go-directive
11 changes: 10 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ OUTPUT ?= $(shell pwd)/_output
INSTALL_PATH ?= $(OUTPUT)/bin
LDFLAGS ?= -w -s -X k8s.io/component-base/version.gitVersion=$(VERSION) -X main.gitVersion=$(VERSION)

GOLANG_DIRECTIVE_VERSION ?= 1.24.0
CURL_RETRIES ?= 3

# flags for ecr-credential-provider artifact promotion
UPLOAD ?= $(OUTPUT)/upload
GCS_LOCATION ?= gs://k8s-staging-provider-aws/releases/
Expand Down Expand Up @@ -120,7 +123,7 @@ e2e.test:
mv tests/e2e/e2e.test e2e.test

.PHONY: check
check: verify-fmt verify-lint vet
check: verify-fmt verify-lint vet verify-go-directive

.PHONY: develop
develop: aws-cloud-controller-manager test update-fmt check
Expand All @@ -142,6 +145,12 @@ verify-lint:
verify-codegen:
./hack/verify-codegen.sh

.PHONY: verify-go-directive
verify-go-directive:
# use the core Cluster API script directly to verify the go directive matches the desired one.
# ref: https://github.com/kubernetes-sigs/cluster-api/blob/v1.10.7/hack/verify-go-directive.sh
curl --retry $(CURL_RETRIES) -fsL https://raw.githubusercontent.com/kubernetes-sigs/cluster-api/refs/tags/v1.11.0/hack/verify-go-directive.sh | bash -s -- -g $(GOLANG_DIRECTIVE_VERSION)

.PHONY: vet
vet:
go vet ./...
Expand Down
Loading