manila-csi-plugin: Auto-configure --nodeid, --nodeaz parameters #2734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
cncf-cla: yes
Member
Author
|
/cc @MaysaMacedo |
Contributor
|
@stephenfin: GitHub didn't allow me to request PR reviews from the following users: MaysaMacedo. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
We're seeing failures in CI related to goproxy.io. There's no need to set this so simply don't. Signed-off-by: Stephen Finucane <[email protected]>
This has not seen any updates in a long time and does not appear to be maintained. Our own doc is out-of-date and references removed options. Just remove the whole thing. Signed-off-by: Stephen Finucane <[email protected]>
Same as we do for Cinder. A separate change will deprecate the respective options. Signed-off-by: Stephen Finucane <[email protected]>
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
These are no longer used or necessary, now that we retrieve this information from the metadata service. Signed-off-by: Stephen Finucane <[email protected]>
To clarify their meaning. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
manila-auto-configure-nodeid-nodeaz
branch
from
e450887 to
5175681
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kayrus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
stephenfin
added a commit
to shiftstack/csi-operator
that referenced
this pull request
Dec 9, 2024
This option is deprecated as the driver can now auto-configure this [1]. We can also remove some unnecessary quoting. Note that we don't remove the option from the NFS driver as that is a separate binary that doesn't support this auto-configuration. [1] kubernetes/cloud-provider-openstack#2734 Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
added a commit
to shiftstack/csi-operator
that referenced
this pull request
Dec 9, 2024
This option is deprecated as the driver can now auto-configure this [1]. We can also remove some unnecessary quoting. Note that we don't remove the option from the NFS driver as that is a separate binary that doesn't support this auto-configuration. [1] kubernetes/cloud-provider-openstack#2734 Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
added a commit
to shiftstack/csi-operator
that referenced
this pull request
Jan 16, 2025
This option is deprecated as the driver can now auto-configure this [1]. We can also remove some unnecessary quoting. Note that we don't remove the option from the NFS driver as that is a separate binary that doesn't support this auto-configuration. [1] kubernetes/cloud-provider-openstack#2734 Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
added a commit
to shiftstack/cloud-provider-openstack
that referenced
this pull request
Apr 4, 2025
%T prints the type. %t prints the word true/false, which is what we want. [1] [1] https://pkg.go.dev/fmt Conflicts: pkg/csi/manila/driver.go NOTE(stephenfin): Merge conflicts are due to the absence of PR kubernetes#2734, which we don't want to backport. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
added a commit
to shiftstack/cloud-provider-openstack
that referenced
this pull request
May 8, 2025
%T prints the type. %t prints the word true/false, which is what we want. [1] [1] https://pkg.go.dev/fmt Conflicts: pkg/csi/manila/driver.go NOTE(stephenfin): Merge conflicts are due to the absence of PR kubernetes#2734, which we don't want to backport. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
added a commit
to shiftstack/cloud-provider-openstack
that referenced
this pull request
May 8, 2025
%T prints the type. %t prints the word true/false, which is what we want. [1] [1] https://pkg.go.dev/fmt Conflicts: pkg/csi/manila/driver.go NOTE(stephenfin): Merge conflicts are due to the absence of PR kubernetes#2734, which we don't want to backport. Signed-off-by: Stephen Finucane <[email protected]>
mandre
pushed a commit
to shiftstack/cloud-provider-openstack
that referenced
this pull request
Jun 13, 2025
%T prints the type. %t prints the word true/false, which is what we want. [1] [1] https://pkg.go.dev/fmt Conflicts: pkg/csi/manila/driver.go NOTE(stephenfin): Merge conflicts are due to the absence of PR kubernetes#2734, which we don't want to backport. Signed-off-by: Stephen Finucane <[email protected]>
mandre
pushed a commit
to shiftstack/cloud-provider-openstack
that referenced
this pull request
Jun 13, 2025
%T prints the type. %t prints the word true/false, which is what we want. [1] [1] https://pkg.go.dev/fmt Conflicts: pkg/csi/manila/driver.go NOTE(stephenfin): Merge conflicts are due to the absence of PR kubernetes#2734, which we don't want to backport. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
added a commit
to shiftstack/csi-operator
that referenced
this pull request
Jun 24, 2025
This option is deprecated as the driver can now auto-configure this [1]. We can also remove some unnecessary quoting. Note that we don't remove the option from the NFS driver as that is a separate binary that doesn't support this auto-configuration. [1] kubernetes/cloud-provider-openstack#2734 Signed-off-by: Stephen Finucane <[email protected]>
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jul 2, 2025
…hen --with-topology=False (#2872) * cinder-csi-plugin, manila-csi-plugin: Correct formatting character %T prints the type. %t prints the word true/false, which is what we want. [1] [1] https://pkg.go.dev/fmt Conflicts: pkg/csi/manila/driver.go NOTE(stephenfin): Merge conflicts are due to the absence of PR #2734, which we don't want to backport. Signed-off-by: Stephen Finucane <[email protected]> * cinder-csi-plugin: Don't report topology capability when --with-topology=False The 'PluginCapability_Service_VOLUME_ACCESSIBILITY_CONSTRAINTS' capability flag determines whether the provisioner attempts to look up topology information from the node or not [1][2]. If we report it but don't return topology information from the node, we end up with failures to provision [3]. Fix the issue by optionally reporting the capability, like Manila already does. [1] https://github.com/kubernetes-csi/external-provisioner/blob/17e2429e9f/pkg/controller/controller.go#L685-L700 [2] https://github.com/kubernetes-csi/external-provisioner/blob/17e2429e9f/pkg/controller/controller.go#L994-L996 [3] https://github.com/kubernetes-csi/external-provisioner/blob/17e2429e9f/pkg/controller/topology.go#L177 Signed-off-by: Stephen Finucane <[email protected]> * manila-csi-plugin: Unify some logging between cinder, manila Signed-off-by: Stephen Finucane <[email protected]> --------- Signed-off-by: Stephen Finucane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
cinder-csi-pluginhas long supported automatic retrieval of the node ID and node AZ information from the metadata service. Introduce this functionality tomanila-csi-pluginnow.Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: