Replace strconv.Quote with strconv.AppendQuote everywhere to reduce allocations
#426
Conversation
Updated the logging functions to utilize cached buffers more effectively by replacing the creation of new byte slices with calls to `AvailableBuffer()`. This change reduces memory allocations and enhances performance across multiple logging components, including `klog`, `klogr_slog`, and `textlogger`. Additionally, modified the JSON serialization in `keyvalues_slog.go` and `keyvalues.go` to leverage the same buffer optimization for quoting string values. This refactor aims to streamline logging operations and improve overall efficiency. Signed-off-by: Anton Sergunov <[email protected]>
Signed-off-by: Anton Sergunov <[email protected]>
Signed-off-by: Anton Sergunov <[email protected]>
Signed-off-by: Anton Sergunov <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: asergunov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-triage
|
This issue is currently awaiting triage. If klog contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @asergunov! |
k8s-ci-robot
added
cncf-cla: no
|
Don't take in account the reported speed improvements. It could be just Laptop heating. It has less allocations for sure. |
pohly
left a comment
pohly
left a comment
There was a problem hiding this comment.
I double-checked performance on an Arrow Lake desktop with pinning to one P-core (to avoid variance). I see moderate improvements:
pkg: k8s.io/klog/v2
...
geomean 61.43n 61.20n -0.37%
pkg: k8s.io/klog/v2/textlogger
...
geomean 586.6n 578.7n -1.35%
But any improvement which doesn't unduly increase complexity is welcome, so thanks for the PR!
@asergunov: can you squash into one commit?
/assign @dims
Tests passed locally, workflows still need to be triggered (don't have permissions for that).
|
i've approved workflows to run @pohly |
4 participants
What this PR does / why we need it:
Spotted calls to
strconv.Quotewhich allocates the new string. Replaced withstrconv.AppendQuote.In most of the places I'm using the pattern:
So we reusing the already allocated buffer if it's available.
The only exception is stack-allocated fixed size buffers we have introduced in #413. As you can see from the
benchmark_out_reduce-allocations-fix-alloc.txtcolumn it's faster in benchmarks as it is. Thebenchmark_out_reduce-allocations.txtis a results with these places also replaced and you can see it performs worse in some cases. So I kept that code untouched.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: