Skip to content

Replace strconv.Quote with strconv.AppendQuote everywhere to reduce allocations #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −5
Open

Replace strconv.Quote with strconv.AppendQuote everywhere to reduce allocations #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fce8ac
Refactor logging buffer usage to improve performance
asergunov Nov 14, 2025
0f1b22b
Fix tests
asergunov Nov 14, 2025
6db40fd
Get constant allocations back
asergunov Nov 14, 2025
5025e08
diff cleanup
asergunov Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/serialize/keyvalues.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ func writeStringValue(b *bytes.Buffer, v string) {
if index == -1 {
b.WriteByte('=')
// Simple string, quote quotation marks and non-printable characters.
b.WriteString(strconv.Quote(v))
b.Write(strconv.AppendQuote(b.AvailableBuffer(), v))
return
}

Expand Down
20 changes: 16 additions & 4 deletions internal/serialize/keyvalues_slog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ func generateJSON(b *bytes.Buffer, v interface{}) {
if i > 0 {
b.WriteByte(',')
}
b.WriteString(strconv.Quote(attr.Key))
b.Write(
strconv.AppendQuote(
b.AvailableBuffer(),
attr.Key))
b.WriteByte(':')
generateJSON(b, attr.Value)
}
Expand All @@ -144,15 +147,24 @@ func generateJSON(b *bytes.Buffer, v interface{}) {
generateJSON(b, v.Any())
}
case fmt.Stringer:
b.WriteString(strconv.Quote(StringerToString(v)))
b.Write(
strconv.AppendQuote(
b.AvailableBuffer(),
StringerToString(v)))
case logr.Marshaler:
generateJSON(b, MarshalerToValue(v))
case slog.LogValuer:
generateJSON(b, slog.AnyValue(v).Resolve().Any())
case string:
b.WriteString(strconv.Quote(v))
b.Write(
strconv.AppendQuote(
b.AvailableBuffer(),
v))
case error:
b.WriteString(strconv.Quote(v.Error()))
b.Write(
strconv.AppendQuote(
b.AvailableBuffer(),
v.Error()))
default:
formatAsJSON(b, v)
}
Expand Down
Loading