Skip to content

Conversation

minikube-bot
Copy link
Collaborator

This PR was auto-generated by make update-kubernetes-version using update-k8s-versions.yml CI Workflow.
Please only merge if all the tests pass.

 M pkg/minikube/constants/constants.go
 M site/content/en/docs/commands/start.md
?? pkg/minikube/bootstrapper/bsutil/testdata/v1.34/

@minikube-bot minikube-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 4, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from medyagh and nirs August 4, 2025 08:05
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 4, 2025
@minikube-pr-bot

This comment has been minimized.

@medyagh medyagh changed the title cd hack && go run update/kubernetes_version/update_kubernetes_version.go Bump Kubernetes version default: v1.33.3 and latest: v1.34.0-beta.0 Bump Kubernetes version default: v1.33.3 and latest: v1.34.0-beta.0 Aug 4, 2025
@medyagh
Copy link
Member

medyagh commented Aug 5, 2025

@ComradeProgrammer can you check why newest kubernetes test fails ?

=== RUN   TestFunctionalNewestKubernetes/Versionv1.34.0-beta.0/serial/StartWithProxy
functional_test.go:2251: (dbg) Run:  out/minikube-linux-amd64 start -p functional-699837 --memory=4096 --apiserver-port=8441 --wait=all --driver=docker  --container-runtime=docker --kubernetes-version=v1.34.0-beta.0
E0804 08:46:47.353392 1582690 cert_rotation.go:172] "Loading client cert failed" err="open /home/jenkins/minikube-integration/21223-1578987/.minikube/profiles/addons-309866/client.crt: no such file or directory" logger="tls-transport-cache.UnhandledError" key="key"

https://storage.googleapis.com/minikube-builds/logs/21223/40792/Docker_Linux.html#fail_TestFunctionalNewestKubernetes%2fVersionv1.34.0-beta.0%2fserial%2fStartWithProxy

@minikube-bot minikube-bot force-pushed the auto_bump_k8s_versions branch from 484a1af to 8f738ff Compare August 5, 2025 21:47
@minikube-bot minikube-bot changed the title Bump Kubernetes version default: v1.33.3 and latest: v1.34.0-beta.0 cd hack && go run update/kubernetes_version/kubernetes_version.go Bump Kubernetes version default: v1.33.3 and latest: v1.34.0-beta.0 Aug 5, 2025
@medyagh medyagh changed the title cd hack && go run update/kubernetes_version/kubernetes_version.go Bump Kubernetes version default: v1.33.3 and latest: v1.34.0-beta.0 Bump Kubernetes version default: v1.33.3 and latest: v1.34.0-beta.0 Aug 5, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_k8s_versions branch from 8f738ff to d037959 Compare August 11, 2025 08:05
@minikube-bot minikube-bot changed the title Bump Kubernetes version default: v1.33.3 and latest: v1.34.0-beta.0 cd hack && go run update/kubernetes_version/kubernetes_version.go Bump Kubernetes version default: v1.33.3 and latest: v1.34.0-rc.1 Aug 11, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21223 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 48.4s    │ 48.5s                  │
│ enable ingress │ 15.1s    │ 15.2s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 50.0s 49.2s 50.7s 45.5s 46.9s
Times for minikube (PR 21223) start: 46.2s 49.0s 47.3s 51.3s 48.6s

Times for minikube ingress: 14.9s 15.0s 15.0s 15.0s 15.5s
Times for minikube (PR 21223) ingress: 16.0s 14.5s 15.0s 15.5s 15.0s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21223 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 24.3s    │ 23.8s                  │
│ enable ingress │ 13.0s    │ 13.0s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 25.1s 24.5s 26.2s 23.9s 21.6s
Times for minikube (PR 21223) start: 23.2s 25.5s 24.7s 22.7s 22.7s

Times for minikube ingress: 13.8s 13.8s 11.3s 12.8s 13.3s
Times for minikube (PR 21223) ingress: 13.3s 12.3s 13.3s 12.3s 13.8s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21223 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.1s    │ 22.6s                  │
│ enable ingress │ 23.6s    │ 24.2s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 21.7s 22.6s 24.3s 23.1s 23.9s
Times for minikube (PR 21223) start: 22.7s 21.9s 23.7s 23.5s 21.2s

Times for minikube ingress: 23.3s 23.3s 23.8s 23.3s 24.3s
Times for minikube (PR 21223) ingress: 22.8s 29.3s 22.8s 23.3s 22.8s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants