Skip to content

MTV-3663 | AAP job template hooks for migration plans #5622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gwencasey96 wants to merge 2 commits into
base: main
Choose a base branch
from

chore: regenerate upstream operator manifests (make update-manifests)

f034c29
Select commit
Loading
Failed to load commit list.
Draft

MTV-3663 | AAP job template hooks for migration plans #5622

chore: regenerate upstream operator manifests (make update-manifests)
f034c29
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 31, 2026 in 48s

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 60 in pkg/controller/plan/hook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "global-sa" 3 times. 

See more on https://sonarcloud.io/project/issues?id=kubev2v_forklift&issues=AZ1B9_tUWRgqseTcYm09&open=AZ1B9_tUWRgqseTcYm09&pullRequest=5622

Check failure on line 1531 in pkg/controller/plan/validation.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "VM: %s hook: %s" 3 times. 

See more on https://sonarcloud.io/project/issues?id=kubev2v_forklift&issues=AZ1B9_j_WRgqseTcYm07&open=AZ1B9_j_WRgqseTcYm07&pullRequest=5622

Check warning on line 160 in pkg/controller/plan/hook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestHookRunner_constructWithFakeClient" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=kubev2v_forklift&issues=AZ1B9_tUWRgqseTcYm1C&open=AZ1B9_tUWRgqseTcYm1C&pullRequest=5622

Check failure on line 97 in pkg/controller/plan/hook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "https://aap.example.com" 3 times. 

See more on https://sonarcloud.io/project/issues?id=kubev2v_forklift&issues=AZ1B9_tUWRgqseTcYm08&open=AZ1B9_tUWRgqseTcYm08&pullRequest=5622

Check warning on line 110 in pkg/controller/plan/hook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestHookSpec_playbookFields" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=kubev2v_forklift&issues=AZ1B9_tUWRgqseTcYm1B&open=AZ1B9_tUWRgqseTcYm1B&pullRequest=5622

Check warning on line 49 in pkg/controller/plan/hook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestHookRunner_template_ServiceAccountName" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=kubev2v_forklift&issues=AZ1B9_tUWRgqseTcYm0_&open=AZ1B9_tUWRgqseTcYm0_&pullRequest=5622

Check warning on line 90 in pkg/controller/plan/hook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestHookSpec_AAPFields" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=kubev2v_forklift&issues=AZ1B9_tUWRgqseTcYm1A&open=AZ1B9_tUWRgqseTcYm1A&pullRequest=5622

Check failure on line 98 in pkg/controller/plan/hook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "aap-token-secret" 3 times. 

See more on https://sonarcloud.io/project/issues?id=kubev2v_forklift&issues=AZ1B9_tUWRgqseTcYm0-&open=AZ1B9_tUWRgqseTcYm0-&pullRequest=5622
View more details on SonarQubeCloud