Skip to content

sig,report: Include release branch failures in report#95

Merged
dhiller merged 1 commit intomainfrom
include-release-failures-report
Sep 26, 2025
Merged

sig,report: Include release branch failures in report#95
dhiller merged 1 commit intomainfrom
include-release-failures-report

Conversation

@brianmcarey
Copy link
Member

What this PR does / why we need it:

With the release branch failures omitted from the report - the numbers displayed in the ci-health README do not match the number of failures in the report which can be confusing.

Include release branch job failures in the sig reports

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


With the release branch failures omitted from the report - the numbers
displayed in the ci-health README do not match the number of failures in
the report which can be confusing.

Include release branch job failures in the sig reports

Signed-off-by: Brian Carey <bcarey@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Sep 17, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question inline

"compute": "sig-compute$|sig-compute-serial$|sig-compute-migrations$|sig-operator$|vgpu$|sev$",
"network": "sig-network$|sriov$",
"storage": "sig-storage$",
"compute": "sig-compute|sig-compute-serial|sig-compute-migrations|sig-operator|vgpu|sev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might also pull in other jobs from the main branch. do we want that?

also do we not want to restrict from which release branches we want to pull in the results?

(maybe I am also overthinking here...)

Suggested change
"compute": "sig-compute|sig-compute-serial|sig-compute-migrations|sig-operator|vgpu|sev",
"compute": "(sig-compute|sig-compute-serial|sig-compute-migrations|sig-operator|vgpu|sev)(-1.[0-9]+)?",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure @dhiller - I think if the e2e job name includes say sig-compute then we should be happy enough that sig-compute own the job. Also the metric includes any jobs with sig-compute in the name

case strings.Contains(job.jobName, "sig-compute") || strings.Contains(job.jobName, "vgpu"):

In a followup PR, I am going to split out sig-operator and add sig-monitoring to generate reports for each of those so that each badge will have its own linked report.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think @dhiller ?

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@dhiller dhiller merged commit 3a2b5f1 into main Sep 26, 2025
3 checks passed
@dhiller dhiller deleted the include-release-failures-report branch September 26, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants