Skip to content

sig,report: Include release branch failures in report #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhiller merged 1 commit into from
Sep 26, 2025
Merged

sig,report: Include release branch failures in report #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/htmlreport/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ type SigFailure struct {
}

var jobRegexAliases = map[string]string{
"compute": "sig-compute$|sig-compute-serial$|sig-compute-migrations$|sig-operator$|vgpu$|sev$",
"network": "sig-network$|sriov$",
"storage": "sig-storage$",
"compute": "sig-compute|sig-compute-serial|sig-compute-migrations|sig-operator|vgpu|sev",
Copy link
Contributor

@dhiller dhiller Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might also pull in other jobs from the main branch. do we want that?

also do we not want to restrict from which release branches we want to pull in the results?

(maybe I am also overthinking here...)

Suggested change
"compute": "sig-compute|sig-compute-serial|sig-compute-migrations|sig-operator|vgpu|sev",
"compute": "(sig-compute|sig-compute-serial|sig-compute-migrations|sig-operator|vgpu|sev)(-1.[0-9]+)?",

Copy link
Member Author

@brianmcarey brianmcarey Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure @dhiller - I think if the e2e job name includes say sig-compute then we should be happy enough that sig-compute own the job. Also the metric includes any jobs with sig-compute in the name

ci-health/pkg/sigretests/main.go

Line 226 in 1d7b85c

case strings.Contains(job.jobName, "sig-compute") || strings.Contains(job.jobName, "vgpu"):

In a followup PR, I am going to split out sig-operator and add sig-monitoring to generate reports for each of those so that each badge will have its own linked report.

Copy link
Member Author

@brianmcarey brianmcarey Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think @dhiller ?

"network": "sig-network|sriov",
"storage": "sig-storage",
}

func fetchResults(resultsPath string) (*HTMLReportResults, error) {
Expand Down