Skip to content

feat: Decouple controller runtime from watcher runtime - listener integrartion #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: Decouple controller runtime from watcher runtime - listener integrartion #2657

wants to merge 14 commits into from

Conversation

medmes
Copy link
Member

@medmes medmes commented Aug 12, 2025

Description
This PR is for the second part/ consumer part of decoupling from controller-runtime library in the runtime-warcher and listener.
It tackle the breaking changes regarding consuming the right new API contract.

Changes proposed in this pull request

  • Create SKR event service which is responsible wrapping the underlying listener package.
  • Delegate the SKR Event Service lifecycle management to the controller-runtime manager.
  • Added type conversions from the exposed listener Custom DTO to generic Event used by controller-runtme.
  • Added unit Tests

Related issue(s)
kyma-project/runtime-watcher#130

@medmes medmes requested a review from a team as a code owner August 12, 2025 07:09
@medmes medmes mentioned this pull request Aug 12, 2025
Closed
3 tasks
@medmes medmes changed the title feat: Decouple the controller runtime from watcher runtime - listener integrartion feat: Decouple controller runtime from watcher runtime - listener integrartion Aug 12, 2025
@medmes medmes linked an issue Aug 12, 2025 that may be closed by this pull request
Decouple controller-runtime from the Runtime Watcher kyma-project/runtime-watcher#130
Closed
3 tasks
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP removed a link to an issue Aug 21, 2025
Decouple controller-runtime from the Runtime Watcher kyma-project/runtime-watcher#130
Closed
3 tasks
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP mentioned this pull request Aug 29, 2025
Merged
@Tomasz-Smelcerz-SAP
Copy link
Member

Tomasz-Smelcerz-SAP commented Aug 29, 2025 •
edited
Loading

Please take a look at: #2697
I think it's beneficial to merge #2697 first.
And only then resume working on this PR, but just as a refactoring task, not required to accomplish kyma-project/runtime-watcher#130)

Tomasz-Smelcerz-SAP
Tomasz-Smelcerz-SAP requested changes Sep 1, 2025
View reviewed changes
Copy link
Member

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest problem I found with this PR is that it doesn't work :(
Are watcher-related tests working? These must be working first using released versions/images.
Please take a look at #2697

@medmes medmes added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@medmes @Tomasz-Smelcerz-SAP