Skip to content

Conversation

Tomasz-Smelcerz-SAP
Copy link
Member

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP commented Aug 29, 2025

Description

This PR is meant as a prerequisite to #2657 , that is: I think we should merge this PR first.
The #2657 is much more complex and it's not clear if this additional complexity is worth it.
Besides that, the #2657 is doing two things at once: It tries to adapt lifecycle-manager to the latest changes in runtime-watcher/listener (which is necessary) and it refactors the event-handling logic (which is not strictly required to accomplish kyma-project/runtime-watcher#130)
In my opinion these two things should NOT be delivered in a single PR as it makes code review unnecessary hard.

Considering that, in order to follow the good practice: first: make it work, then make it pretty, this PR introduces just the minimal changes required to make lifecycle-manager compatible with recent changes in the runtime-watcher/listener module.

Changes proposed in this pull request:

  • Switch to runtime-watcher/listener/pkg/v2 types
  • Use the latest runtime-watcher:2.0.0 image
  • Make necessary configuration changes
  • Add simple "AdaptEvents` function for channel conversion purpose.

Related issue(s)
kyma-project/runtime-watcher#130

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP requested a review from a team as a code owner August 29, 2025 06:37
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP force-pushed the feat/adjust_to_changes_in_listener_v2 branch from a8aff69 to 0b013a4 Compare August 29, 2025 06:41
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP changed the title Adjust to changes in listener/pkg/v2 feat: Adjust to changes in listener/pkg/v2 Aug 29, 2025
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP force-pushed the feat/adjust_to_changes_in_listener_v2 branch from 67bdff3 to 0b013a4 Compare August 29, 2025 07:10
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP force-pushed the feat/adjust_to_changes_in_listener_v2 branch from 04e9caa to 9e388ac Compare August 29, 2025 09:59
auto-merge was automatically disabled August 30, 2025 12:37

Pull request was closed

c-pius
c-pius previously approved these changes Sep 1, 2025
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question about the watcherEventAdapter. Is it temporary until things are made pretty or going to stay? Should we add the internal/controller pkg to the unit test coverage thresholds?

And I really appreciate your detailed PR descriptions and change summaries. Made it super easy to follow through the preceding changes in runtime-watcher leading up to this PR 👍🏻
CC: @jacekon

@Tomasz-Smelcerz-SAP
Copy link
Member Author

Tomasz-Smelcerz-SAP commented Sep 2, 2025

One question about the watcherEventAdapter. Is it temporary until things are made pretty or going to stay? Should we add the internal/controller pkg to the unit test coverage thresholds?

We can do this, yes. But it has 100% now, so it can only get worse over time :)
But seriously - I think it is sort-of temporary and will be replaced by a bigger refactoring like the one introduced in #2657
Feel free to suggest a "better place" (a dedicated package?) for this thing - until the "big refactoring" comes.

Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this, yes. But it has 100% now, so it can only get worse over time :)

That's the point of the action 😄

But seriously - I think it is sort-of temporary and will be replaced by a bigger refactoring like the one introduced in #2657
Feel free to suggest a "better place" (a dedicated package?) for this thing - until the "big refactoring" comes.

No it is okay for me already as indicated by my previous approval. Especially now since you mentioned that this will be refactored soon anyway.

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP enabled auto-merge (squash) September 2, 2025 09:14
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP merged commit 1d43296 into kyma-project:main Sep 2, 2025
120 of 122 checks passed
@c-pius c-pius assigned Tomasz-Smelcerz-SAP and unassigned c-pius Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants