fix: ensure migrate:make respects destroyOnExit config#374
Open
mx1700 wants to merge 1 commit intokysely-org:mainfrom
Open
fix: ensure migrate:make respects destroyOnExit config#374mx1700 wants to merge 1 commit intokysely-org:mainfrom
mx1700 wants to merge 1 commit intokysely-org:mainfrom
Conversation
When passing a pre-configured Kysely instance via 'kysely' config option, migrate:make command would not destroy the instance after execution, causing the process to hang when connection pool settings like 'maxIdle' create persistent connections. This change wraps the migrate:make command execution in usingKysely() to ensure destroyOnExit logic is applied consistently with other commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kyselyinstance viakyselyconfig option,migrate:makecommand would not destroy the instance after executionmaxIdlecreate persistent connectionsmigrate:up,migrate:down,migrate:listalready useusingKysely()wrapper which handles cleanupRoot Cause
The
MakeCommandimplementation directly calledgetConfigOrFail()and then proceeded to create the migration file without wrapping execution inusingKysely(). This skipped thedestroyOnExitcleanup logic.Fix
Wrap the
migrate:makecommand execution inusingKysely()to ensuredestroyOnExitlogic is applied consistently with other commands.Testing
Related
Addresses issue where
migrate:makehangs after creating migration file when using connection pool settings likemaxIdle=2in database URL.