Skip to content

fix: ensure migrate:make respects destroyOnExit config #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mx1700 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure migrate:make respects destroyOnExit config #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 25 additions & 22 deletions src/commands/migrate/make.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { CommonArgs } from '../../arguments/common.mjs'
import { assertExtension, ExtensionArg } from '../../arguments/extension.mjs'
import { createMigrationNameArg } from '../../arguments/migration-name.mjs'
import { getConfigOrFail } from '../../config/get-config.mjs'
import { usingKysely } from '../../kysely/using-kysely.mjs'
import { createSubcommand } from '../../utils/create-subcommand.mjs'
import { defineArgs } from '../../utils/define-args.mjs'
import { defineCommand } from '../../utils/define-command.mjs'
Expand All @@ -26,40 +27,42 @@ const Command = defineCommand(args, {

const config = await getConfigOrFail(args)

assertExtension(extension, config, 'migrations')
await usingKysely(config, async () => {
assertExtension(extension, config, 'migrations')

const { getMigrationPrefix, migrationFolder } = config.migrations
const { getMigrationPrefix, migrationFolder } = config.migrations

const wasMigrationsFolderCreated = Boolean(
await mkdir(migrationFolder, { recursive: true }),
)
const wasMigrationsFolderCreated = Boolean(
await mkdir(migrationFolder, { recursive: true }),
)

if (wasMigrationsFolderCreated) {
consola.debug('Migrations folder created')
}
if (wasMigrationsFolderCreated) {
consola.debug('Migrations folder created')
}

const filename = `${await getMigrationPrefix()}${
args.migration_name
}.${extension}`
const filename = `${await getMigrationPrefix()}${
args.migration_name
}.${extension}`

consola.debug('Filename:', filename)
consola.debug('Filename:', filename)

const filePath = join(migrationFolder, filename)
const filePath = join(migrationFolder, filename)

consola.debug('File path:', filePath)
consola.debug('File path:', filePath)

const templateExtension = await getTemplateExtension(extension)
const templateExtension = await getTemplateExtension(extension)

const templatePath = join(
__dirname,
`templates/migration-template.${templateExtension}`,
)
const templatePath = join(
__dirname,
`templates/migration-template.${templateExtension}`,
)

consola.debug('Template path:', templatePath)
consola.debug('Template path:', templatePath)

await copyFile(templatePath, filePath)
await copyFile(templatePath, filePath)

consola.success(`Created migration file at ${filePath}`)
consola.success(`Created migration file at ${filePath}`)
})
},
})

Expand Down