Sync structure selection between jupyter and viewers #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sofiia-chorna
left a comment
sofiia-chorna
left a comment
There was a problem hiding this comment.
from my tests, it is working fine, streamlit is all good as well
Collaborator
sofiia-chorna
left a comment
sofiia-chorna
left a comment
There was a problem hiding this comment.
some small things i noticed:
- there is an error in the console for the Chemical Shielding example (but it seems to be working fine anyways)
dataset.json
- when we set an id outside the valid range, the info panel is updated with this number. we can live with it but perhaps it is not perfect
…ctiveAtoms existence
sofiia-chorna
approved these changes
Jan 9, 2026
Collaborator
sofiia-chorna
left a comment
sofiia-chorna
left a comment
There was a problem hiding this comment.
Works fine, streamlit is OK as well, thanks!
…decoupling from options object
…revent background loops
Luthaf
reviewed
Jan 9, 2026
| const activeAtoms = this.visualizer.indexer.activeAtoms(structure); | ||
|
|
||
| if (activeAtoms && activeAtoms.length > 0) { | ||
| if (binarySearch(activeAtoms, atom) === -1) { |
Contributor
There was a problem hiding this comment.
why is this a binary search, instead of some standard search on an array?
Contributor
Author
There was a problem hiding this comment.
it is how all this was already implemented (binarysearch was introduced 4 years ago ^_^) I assumed it was because of the sparsity of the environment array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.