-
Notifications
You must be signed in to change notification settings - Fork 43
Sync structure selection between jupyter and viewers #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 22 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
a5f2aff
feat: reimplement bidirectional selection sync
ceriottm c0a4bfa
Remove stray flag
ceriottm b090d81
feat: reimplement bidirectional selection sync and active viewer sync
ceriottm ad49dcb
fix: ensure selection is synced after settings application
ceriottm d7ef855
fix: solve settings conflict and ensure selection update on settings …
ceriottm 03ac5fb
fix: allow concurrent structure requests
ceriottm 3623ecc
fix: add active_viewer listener and fix structure skipping
ceriottm 242fd0c
fix: relax structure request concurrency check to support grid
ceriottm f43f6bd
fix: explicitly sync map activation when active viewer changes
ceriottm 5c17c2f
fix: robustness against setting conflicts and race conditions
ceriottm c04317b
fix: add missing closing brace in DefaultVisualizer.applySettings
ceriottm 7ce8c9c
Lint
ceriottm 605aa6f
fix: propagate settings application errors to UI warnings
ceriottm ecb7df9
fix: improve error message for viewer settings count mismatch
ceriottm 1a95c88
style: refactor initialization logic into _initializeVisualizer
ceriottm 57f13ee
fix: sync active viewer when removing viewers
ceriottm 9101878
fix: hook into removeViewer to correctly sync active viewer index
ceriottm 3b633a3
Corrected small bug when removing viewers
ceriottm 7dfb3b5
fix: preserve atom selection when changing structure in UI
ceriottm 4ad16b3
fix: support partial selection updates and preserve atom selection
ceriottm 3ec9d52
Lint
ceriottm c837ce2
Also preserve atom index during fast forward
ceriottm b73a5c7
fix: prevent TypeError when switching target and preserve atom index …
ceriottm d725c98
fix: validate structure index in selection and warn on invalid requests
ceriottm 99505c3
fix: show invalid selection warning in UI
ceriottm 6ca9254
fix: prevent crash when setting invalid structure index by checking a…
ceriottm 9575774
Lint
ceriottm 3796b11
fix: prevent loading viewer with invalid structure index in _refreshCell
ceriottm 2b9ae69
Lower a bit the limit for dropping frames
ceriottm 71a9080
fix: smart rate limiting for structure requests based on playback status
ceriottm 5edc03c
Lint
ceriottm 57da463
style: refactor initialization logic into _initializeVisualizer
ceriottm 372c04f
fix: prevent duplicate requests by locking model updates in _updatePy…
ceriottm a22a961
fix: ensure playback delay updates persist after settings refresh by …
ceriottm 1669152
style: remove debug console logs
ceriottm 5f3bc7f
fix: persist setting observers across option refreshes to ensure play…
ceriottm 52c0f00
fix: stop playback when switching targets or removing visualizer to p…
ceriottm 3b7432a
Added a brief documentation of the traitlets
ceriottm c62595b
Link to traitlets docs
ceriottm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,4 +85,4 @@ | |
| .visualizer-map-mode { | ||
| display: block; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.