fix(FR-1501): fix file upload status tracking and error handling #4412

ironAiken2 · 2025-10-20T05:09:59Z

Changes

Fixes file upload status tracking and progress calculation issues, particularly for concurrent uploads. Refactored the upload state management to properly track upload progress using bytes instead of just file counts.

Key Changes

Enhanced State Management Structure
Fixed Progress Calculation

Problem: Progress was only tracked by file count, not actual bytes uploaded
Solution:
- Added completedBytes to track actual upload progress
- Added totalExpectedSize for accurate percentage calculation
- Progress now shows: completedBytes / totalExpectedSize * 100

Fixed Cumulative Bytes Issue

Problem: onProgress callback provides cumulative bytesUploaded, not incremental
Solution: Calculate delta bytes for each progress update

  let previousBytesUploaded = 0;
  const deltaBytes = bytesUploaded - previousBytesUploaded;
  previousBytesUploaded = bytesUploaded;

Improved Concurrent Upload Handling

Problem: When starting new uploads while others are in progress, total size wasn't properly accumulated
Solution:
- totalExpectedSize accumulates across all upload requests
- All progress callbacks reference the same total from state
- Proper reset when all uploads complete

Better Upload Status Notifications

Progress notifications now show both file count and byte-based percentage
More accurate progress tracking during uploads
Proper cleanup of state after completion

Testing

Single file upload progress tracking
Multiple files upload (folder) progress tracking
Concurrent uploads (starting new upload while another
is in progress)
Upload failure handling
Progress percentage accuracy

Technical Details

The main issue was that the original implementation only tracked file names without considering actual bytes uploaded. This led to inaccurate progress reporting, especially for files of varying sizes. The new implementation:

Tracks both file counts and bytes for comprehensive progress reporting
Properly handles cumulative vs incremental byte reporting from the TUS upload library
Maintains a single source of truth (totalExpectedSize) for all concurrent uploads
Correctly accumulates sizes when new uploads are added

Checklist:

Documentation
Minimum required manager version
Specific setting for review
Minimum requirements to check during review
Test case: Upload multiple files and verify status tracking works correctly

ironAiken2 · 2025-10-20T05:10:21Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-10-20T05:12:31Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	4.66%	532/11416
🔴	Branches	3.77%	302/8008
🔴	Functions	2.88%	102/3544
🔴	Lines	4.61%	514/11157

Test suite run success

121 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from d79efea

Copilot

Pull Request Overview

Fixes inaccurate and fragile file upload status tracking by restructuring status data and improving progress calculation and notifications.

Introduces structured UploadStatus objects with vFolderNames and totalSize.
Adds byte-based progress and concurrent uploads (PQueue concurrency 10).
Adjusts FolderExplorer to new status shape.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
react/src/components/FolderExplorer.tsx	Updated empty-pending check to match new nested status structure.
react/src/components/FileUploadManager.tsx	Refactored data structures, progress computation, notification messaging, and concurrency.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

react/src/components/FolderExplorer.tsx

react/src/components/FileUploadManager.tsx

agatha197

please apply copilot's reviews and resolve conflicts

react/src/components/FileUploadManager.tsx

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

react/src/components/FileUploadManager.tsx

yomybaby

LGTM

agatha197

LGTM

graphite-app · 2025-10-28T09:47:34Z

Merge activity

Oct 28, 9:47 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Oct 28, 9:49 AM UTC: Merged by the Graphite merge queue.

Resolves #4316 ([FR-1501](https://lablup.atlassian.net/browse/FR-1501)) ## Changes Fixes file upload status tracking and progress calculation issues, particularly for concurrent uploads. Refactored the upload state management to properly track upload progress using bytes instead of just file counts. ### Key Changes 1. Enhanced State Management Structure 2. Fixed Progress Calculation - Problem: Progress was only tracked by file count, not actual bytes uploaded - Solution: - Added completedBytes to track actual upload progress - Added totalExpectedSize for accurate percentage calculation - Progress now shows: completedBytes / totalExpectedSize * 100 3. Fixed Cumulative Bytes Issue - Problem: onProgress callback provides cumulative bytesUploaded, not incremental - Solution: Calculate delta bytes for each progress update ``` let previousBytesUploaded = 0; const deltaBytes = bytesUploaded - previousBytesUploaded; previousBytesUploaded = bytesUploaded; ``` 4. Improved Concurrent Upload Handling - Problem: When starting new uploads while others are in progress, total size wasn't properly accumulated - Solution: - totalExpectedSize accumulates across all upload requests - All progress callbacks reference the same total from state - Proper reset when all uploads complete 5. Better Upload Status Notifications - Progress notifications now show both file count and byte-based percentage - More accurate progress tracking during uploads - Proper cleanup of state after completion Testing - Single file upload progress tracking - Multiple files upload (folder) progress tracking - Concurrent uploads (starting new upload while another is in progress) - Upload failure handling - Progress percentage accuracy Technical Details The main issue was that the original implementation only tracked file names without considering actual bytes uploaded. This led to inaccurate progress reporting, especially for files of varying sizes. The new implementation: 1. Tracks both file counts and bytes for comprehensive progress reporting 2. Properly handles cumulative vs incremental byte reporting from the TUS upload library 3. Maintains a single source of truth (totalExpectedSize) for all concurrent uploads 4. Correctly accumulates sizes when new uploads are added **Checklist:** - [ ] Documentation - [ ] Minimum required manager version - [ ] Specific setting for review - [ ] Minimum requirements to check during review - [x] Test case: Upload multiple files and verify status tracking works correctly [FR-1501]: https://lablup.atlassian.net/browse/FR-1501?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

github-actions bot assigned ironAiken2 Oct 20, 2025

github-actions bot added the size:L 100~500 LoC label Oct 20, 2025

ironAiken2 requested review from agatha197, nowgnuesLee and yomybaby October 20, 2025 05:11

ironAiken2 marked this pull request as ready for review October 20, 2025 05:12

Copilot AI review requested due to automatic review settings October 20, 2025 05:12

Copilot AI reviewed Oct 20, 2025

View reviewed changes

ironAiken2 force-pushed the fix/FR-1501-file-upload-status-tracking branch from d5cfaff to 3f7e879 Compare October 20, 2025 07:23

agatha197 requested changes Oct 22, 2025

View reviewed changes

react/src/components/FileUploadManager.tsx Outdated Show resolved Hide resolved

ironAiken2 force-pushed the fix/FR-1501-file-upload-status-tracking branch 3 times, most recently from bbb4912 to c4f7e84 Compare October 27, 2025 06:34

ironAiken2 requested review from agatha197 and Copilot October 27, 2025 06:34

Copilot AI reviewed Oct 27, 2025

View reviewed changes

ironAiken2 force-pushed the fix/FR-1501-file-upload-status-tracking branch from c4f7e84 to 8a3b9bd Compare October 27, 2025 06:44

ironAiken2 marked this pull request as draft October 27, 2025 08:22

ironAiken2 force-pushed the fix/FR-1501-file-upload-status-tracking branch from 8a3b9bd to 443b82c Compare October 28, 2025 03:59

github-actions bot added area:ux UI / UX issue. area:i18n Localization labels Oct 28, 2025

ironAiken2 marked this pull request as ready for review October 28, 2025 03:59

ironAiken2 force-pushed the fix/FR-1501-file-upload-status-tracking branch from 443b82c to a73aed7 Compare October 28, 2025 04:51

ironAiken2 mentioned this pull request Oct 28, 2025

feat(FR-1617): add user setting for maximum concurrent file upload limit #4460

Open

4 tasks

yomybaby requested changes Oct 28, 2025

View reviewed changes

react/src/components/FileUploadManager.tsx Show resolved Hide resolved

ironAiken2 force-pushed the fix/FR-1501-file-upload-status-tracking branch from a73aed7 to f2deff6 Compare October 28, 2025 08:17

github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Oct 28, 2025

yomybaby approved these changes Oct 28, 2025

View reviewed changes

agatha197 approved these changes Oct 28, 2025

View reviewed changes

yomybaby force-pushed the fix/FR-1501-file-upload-status-tracking branch from f2deff6 to c08b298 Compare October 28, 2025 09:46

graphite-app bot force-pushed the fix/FR-1501-file-upload-status-tracking branch from c08b298 to d79efea Compare October 28, 2025 09:47

graphite-app bot merged commit d79efea into main Oct 28, 2025
11 checks passed

graphite-app bot deleted the fix/FR-1501-file-upload-status-tracking branch October 28, 2025 09:49

github-pages bot deployed to github-pages October 28, 2025 09:49 View deployment

vercel bot deployed to Production October 28, 2025 10:08 View deployment

Uh oh!

fix(FR-1501): fix file upload status tracking and error handling #4412

fix(FR-1501): fix file upload status tracking and error handling #4412

Conversation

ironAiken2 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Key Changes

Uh oh!

ironAiken2 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agatha197 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

agatha197 left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ironAiken2 commented Oct 20, 2025 •

edited

Loading

ironAiken2 commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading

Coverage report for `./react`

graphite-app bot commented Oct 28, 2025 •

edited

Loading