feat(FR-1617): add user setting for maximum concurrent file upload limit #4460
+219
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:ux
5 tasks
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.66% | 532/11428 |
| 🔴 | Branches | 3.77% | 302/8012 |
| 🔴 | Functions | 2.88% | 102/3544 |
| 🔴 | Lines | 4.6% | 514/11169 |
Test suite run success
121 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from fb6a51c
ironAiken2
force-pushed
the
feat/FR-1617-max-concurrent-upload-setting
branch
from
35d6723 to
353701d
Compare
ironAiken2
force-pushed
the
fix/FR-1501-file-upload-status-tracking
branch
from
a73aed7 to
f2deff6
Compare
yomybaby
force-pushed
the
fix/FR-1501-file-upload-status-tracking
branch
from
f2deff6 to
c08b298
Compare
yomybaby
force-pushed
the
feat/FR-1617-max-concurrent-upload-setting
branch
from
353701d to
ebb34a8
Compare
graphite-app
bot
changed the base branch from
fix/FR-1501-file-upload-status-tracking
to
graphite-base/4460
graphite-app
bot
force-pushed
the
feat/FR-1617-max-concurrent-upload-setting
branch
from
ebb34a8 to
f887707
Compare
graphite-app
bot
force-pushed
the
graphite-base/4460
branch
from
c08b298 to
d79efea
Compare
graphite-app
bot
force-pushed
the
feat/FR-1617-max-concurrent-upload-setting
branch
from
f887707 to
371c676
Compare
ironAiken2
force-pushed
the
feat/FR-1617-max-concurrent-upload-setting
branch
from
371c676 to
6012c4a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements a user-configurable setting to control the maximum number of concurrent file uploads in the file explorer. Users can now adjust upload concurrency (2-5 concurrent uploads) based on their network conditions and system capabilities. The default value is 2 concurrent uploads.
- Added
max_concurrent_uploadsfield to UserSettings interface and created UI control in UserSettingsPage - Modified FileUploadManager to use PQueue with user-configured concurrency and improved error handling
- Added translations for the new setting across all supported languages
- Applied minor UI improvements to notification components and removed unused import
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| react/src/hooks/useBAISetting.tsx | Added max_concurrent_uploads field to UserSettings interface |
| react/src/pages/UserSettingsPage.tsx | Created select dropdown UI control for max concurrent uploads setting (values: 2-5) |
| react/src/components/FileUploadManager.tsx | Updated to use user-configured concurrency via PQueue and refactored error handling |
| react/src/components/FolderExplorerOpener.tsx | Removed unused BAIUnmountAfterClose wrapper component |
| react/src/components/BAISessionNotificationItem.tsx | Added max height and overflow styles to notification extra description card |
| react/src/components/BAIGeneralNotificationItem.tsx | Added max height and overflow styles to notification extra description card |
| resources/i18n/*.json | Added translations for MaxConcurrentUploads and DescMaxConcurrentUploads across all language files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
…mit (#4460) Resolves #4459 ([FR-1617](https://lablup.atlassian.net/browse/FR-1617)) ## Summary Implement a user-configurable setting to control the maximum number of concurrent file uploads in the file explorer. This feature allows users to adjust upload performance based on their network conditions and system capabilities. ## Changes - Added `max_concurrent_uploads` field to UserSettings interface - Created UI control in UserSettingsPage with select dropdown (values: 2-5) - Modified FileUploadManager to use PQueue with user-configured concurrency - Added translations for the new setting in all language files ## Implementation Details - Setting stored in localStorage with key `backendaiwebui.settings.user.max_concurrent_uploads` - Default value: 2 concurrent uploads - Range: 2-5 concurrent uploads - Setting takes effect immediately for new upload operations ## Testing - [ ] Verify setting persists across sessions - [ ] Confirm concurrent upload limit is respected - [ ] Check all translations are displayed correctly - [ ] Test with various network conditions [FR-1617]: https://lablup.atlassian.net/browse/FR-1617?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
bot
force-pushed
the
feat/FR-1617-max-concurrent-upload-setting
branch
from
6012c4a to
fb6a51c
Compare
graphite-app
bot
deleted the
feat/FR-1617-max-concurrent-upload-setting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4459 (FR-1617)
Summary
Implement a user-configurable setting to control the maximum number of concurrent file uploads in the file explorer. This feature allows users to adjust upload performance based on their network conditions and system capabilities.
Changes
max_concurrent_uploadsfield to UserSettings interfaceImplementation Details
backendaiwebui.settings.user.max_concurrent_uploadsTesting