Test C++11 code on GHA with C++98 config.#1926
Test C++11 code on GHA with C++98 config.#1926s-trinh wants to merge 5 commits intolagadic:masterfrom
Conversation
185e741 to
5d592da
Compare
… in vpDetectorAprilTag when building with C++98.
|
@s-trinh The following error with Apriltag (link to GHA) line 1957 is fixed in PR #1927, with commit 572d511 Having this error means for me that the build is in cxx98 and not cxx11. This is confirmed with the option |
|
Commit 2 and 3 here are without The C++98 builds should have failed long time ago. Commit 1: everything passed but should not. I even put C++11 code directly in vpMath to make it fail. But the build still succeeded. The log: https://github.com/lagadic/visp/actions/runs/23050111741/job/66948887696 Gives plenty of
|
|
@s-trinh I agree that there is something weird. With visp-3.6.0 when Some changes were introduced... |
…d test build with C++11 code.
6ef8a92 to
87d3c83
Compare
|
@fspindle |

There seems to be an issue with C++98 builds when
ur_rtdeis built:- name: Install ur_rtde dependency run: | sudo add-apt-repository -y ppa:sdurobotics/ur-rtde sudo apt-get update sudo apt install -y librtde librtde-dev libboost-system-dev libboost-thread-dev libboost-program-options-devVISP_CXX_STANDARDis correctly set (VISP_CXX_STANDARD < VISP_CXX_STANDARD_11)cf the raw log where
-std=c++11flag is passed:ur_rtde