Fix API authentication errors returning HTML instead of JSON #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unauthenticated users attempt deletion requests, the API returns HTML error pages instead of JSON. The frontend cannot parse HTML as JSON, triggering catch blocks that show "网络错误或服务器异常,请稍后再试" instead of the actual error message "需要登录".
Changes
Modified
middleware/error_display.jsto detect API requests and return JSON responses:Impact
Fixes authentication error handling for all API endpoints using
requireLoginorrequireAdminmiddleware:/api/deletion/:type/:id)/notification/api,/notification/:id/read,/notification/read-all)/admin/api/*)Users now see "需要登录" instead of generic network errors when attempting authenticated actions while logged out.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
spider-benben.imken.devnode -e import('./app.js').then(() => console.log('OK')).catch(e => console.error(e))(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.