Skip to content

Fix API authentication errors returning HTML instead of JSON #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix API authentication errors returning HTML instead of JSON #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1136c0d
Initial plan
Copilot Nov 4, 2025
a23a163
Fix authentication error handling to return JSON for API requests
Copilot Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions middleware/error_display.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
import { makeResponse } from "../core/utils.js";

export default (err, req, res, next) => {
// Check if this is an API/JSON request
const isJsonRequest = req.path.startsWith('/api/') ||
req.xhr ||
req.headers.accept?.includes('application/json');

if (isJsonRequest) {
// Return JSON error response
return res.json(makeResponse(false, { message: err.message }));
}

// Return HTML error page for regular requests
res.render('system/error.njk', { title: "错误", error_message: err.message });
}