fix: ensure raw_stream.response is httpx.Response in langfuse streaming adapter #1409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Langfuse is enabled, the object passed to OpenAI’s stream manager as
raw_streamis adapter LangfuseResponseGeneratorAsync. The OpenAI manager setsself._response = raw_stream.responseand then callsawait self._response.aclose().LangfuseResponseGeneratorAsyncpreviously setresponseto theAsyncStreamitself (not tohttpx.Response), so the manager tried to callaclose()on anAsyncStream, causing:Steps to reproduce
Important
Ensure
raw_stream.responseishttpx.Responseby renamingresponsetostreamand settingself.responsetostream.responsein relevant classes and functions.raw_stream.responseishttpx.Responsein async adapter by renamingresponsetostreamin_wrapand_wrap_asyncfunctions.self.responsetostream.responseinLangfuseResponseGeneratorSyncandLangfuseResponseGeneratorAsyncclasses.LangfuseResponseGeneratorSync: Renamedresponsetostreamand setself.responsetostream.response.LangfuseResponseGeneratorAsync: Renamedresponsetostreamand setself.responsetostream.response._wrap: Renamedresponsetostream._wrap_async: Renamedresponsetostream.This description was created by
for 816c68a. You can customize this summary. It will automatically update as commits are pushed.