Skip to content

fix: ensure raw_stream.response is httpx.Response in langfuse streaming adapter #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure raw_stream.response is httpx.Response in langfuse streaming adapter #1409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions langfuse/openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,7 @@ def _wrap(
if _is_streaming_response(openai_response):
return LangfuseResponseGeneratorSync(
resource=open_ai_resource,
response=openai_response,
stream=openai_response,
generation=generation,
)

Expand Down Expand Up @@ -913,7 +913,7 @@ async def _wrap_async(
if _is_streaming_response(openai_response):
return LangfuseResponseGeneratorAsync(
resource=open_ai_resource,
response=openai_response,
stream=openai_response,
generation=generation,
)

Expand Down Expand Up @@ -977,19 +977,20 @@ def __init__(
self,
*,
resource: Any,
response: Any,
stream: Any,
generation: Any,
) -> None:
self.items: list[Any] = []

self.resource = resource
self.response = response
self.stream = stream
self.response = stream.response
self.generation = generation
self.completion_start_time: Optional[datetime] = None

def __iter__(self) -> Any:
try:
for i in self.response:
for i in self.stream:
self.items.append(i)

if self.completion_start_time is None:
Expand All @@ -1001,7 +1002,7 @@ def __iter__(self) -> Any:

def __next__(self) -> Any:
try:
item = self.response.__next__()
item = self.stream.__next__()
self.items.append(item)

if self.completion_start_time is None:
Expand Down Expand Up @@ -1048,19 +1049,20 @@ def __init__(
self,
*,
resource: Any,
response: Any,
stream: Any,
generation: Any,
) -> None:
self.items: list[Any] = []

self.resource = resource
self.response = response
self.stream = stream
self.response = stream.response
self.generation = generation
self.completion_start_time: Optional[datetime] = None

async def __aiter__(self) -> Any:
try:
async for i in self.response:
async for i in self.stream:
self.items.append(i)

if self.completion_start_time is None:
Expand All @@ -1072,7 +1074,7 @@ async def __aiter__(self) -> Any:

async def __anext__(self) -> Any:
try:
item = await self.response.__anext__()
item = await self.stream.__anext__()
self.items.append(item)

if self.completion_start_time is None:
Expand Down