fix/issue 18752 proxy env fallback new

[fghpdf]

Description

This PR adds support for lowercase proxy environment variables as a fallback when uppercase versions are not set.

Changes

• Added fallback logic in SetDefault() method to check lowercase http_proxy, https_proxy, and no_proxy when uppercase versions (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) are empty
• Added new helper function setDefaultStringFromEnv() to read from environment variables

Fixes

Fixes langgenius/dify#18752

Testing

• Code compiles successfully
• Follows the same pattern as other configuration defaults in the codebase

Behavior

• If HTTP_PROXY is set, it will be used (backward compatible)
• If HTTP_PROXY is empty but http_proxy is set, http_proxy will be used
• Same logic applies to HTTPS_PROXY/https_proxy and NO_PROXY/no_proxy

[gemini-code-assist]

Summary of Changes

Hello @fghpdf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's proxy configuration handling by introducing a fallback mechanism. It ensures that proxy settings are correctly applied even when only lowercase environment variables are provided, improving the flexibility and reliability of network communication within the application. The change also refactors the implementation to align with existing utility functions.

Highlights

• Proxy Environment Variable Fallback: Implemented support for falling back to lowercase proxy environment variables (e.g., http_proxy) if the corresponding uppercase variables are not set, ensuring more robust proxy configuration.
• Code Refactoring: Refactored the proxy environment variable fallback logic to utilize the existing setDefaultString helper function, promoting code consistency and reusability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds fallback support for lowercase proxy environment variables. The implementation is straightforward but contains a subtle bug related to handling explicitly empty environment variables, which could lead to unexpected behavior. I've provided a review comment with a suggested fix to ensure the logic is robust and aligns with user expectations when configuring proxies.