Skip to content

fix/issue 18752 proxy env fallback new #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fghpdf wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix/issue 18752 proxy env fallback new #562

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4705636
fix: support lowercase proxy environment variables fallback
fghpdf Jan 8, 2026
b1dc71b
refactor: use existing setDefaultString for proxy env fallback
fghpdf Jan 9, 2026
9dfa896
fix: use os.LookupEnv to distinguish unset vs empty proxy variables
fghpdf Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/types/app/default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package app

import (
"os"

"github.com/langgenius/dify-cloud-kit/oss"
"golang.org/x/exp/constraints"
)
Expand Down Expand Up @@ -38,6 +40,17 @@ func (config *Config) SetDefault() {
setDefaultInt(&config.PythonEnvInitTimeout, 120)
setDefaultInt(&config.DifyInvocationWriteTimeout, 5000)
setDefaultInt(&config.DifyInvocationReadTimeout, 240000)

// fallback to lowercase proxy environment variables if uppercase is not set
if _, ok := os.LookupEnv("HTTP_PROXY"); !ok {
config.HttpProxy = os.Getenv("http_proxy")
}
if _, ok := os.LookupEnv("HTTPS_PROXY"); !ok {
config.HttpsProxy = os.Getenv("https_proxy")
}
if _, ok := os.LookupEnv("NO_PROXY"); !ok {
config.NoProxy = os.Getenv("no_proxy")
}
if config.DBType == DB_TYPE_POSTGRESQL || config.DBType == DB_TYPE_PG_BOUNCER {
setDefaultString(&config.DBDefaultDatabase, "postgres")
} else if config.DBType == DB_TYPE_MYSQL {
Expand Down